-
Notifications
You must be signed in to change notification settings - Fork 390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VS2017RC3 - Portable class library in TargetFrameworks errors on build #1369
Comments
You need to use the short TFM and use properties: https://github.com/onovotny/Zeroconf/blob/dev/Zeroconf/Zeroconf.csproj#L32-L37 For PCL 259, the properties would be:
|
Note that the Version=v0.0 bit is due to a bug and is being tracked here: dotnet/sdk#492 But the above should work for you. Downside though -- requires Windows to build, not |
I have a PCL build working. Will PCL ever work with dotnet build? |
https://github.com/dotnet/cli/issues/5504 tracks building non-.NET Core projects with the CLI. Adding these propertygroups to the SDK so that this is supported OOB is tracked by dotnet/sdk#491 |
@onovotny How do you figure out where on disk msbuild for VS 15.0 is located? Is there a registry key with that information somewhere? I don't want to bake the path on my local computer into a build script. |
There's no real path that I know of, but that's the value used in the new project templates. It's controlled by Do file -> new portable class library then see what the imports statement is at the bottom.
It's the location that all of the project templates use, so I have to assume it's safe to use that path elsewhere as well. Otherwise PCL projects won't load/build at all for VS :) |
Doh, just re-read your question and totally missed it...need coffee! https://github.com/Microsoft/vssetup.powershell That's probably what you want; it'll show you the available instances of VS (and from there you can get the path to MSBuild from the top level folder). |
See also dotnet/msbuild#1377 |
I used the same format that I did in project.sjon:
Error:
The text was updated successfully, but these errors were encountered: