Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get prompt to rename a type when moving it from one folder to another #363

Closed
davkean opened this issue Aug 18, 2016 · 6 comments · Fixed by #920
Closed

Get prompt to rename a type when moving it from one folder to another #363

davkean opened this issue Aug 18, 2016 · 6 comments · Fixed by #920
Assignees

Comments

@davkean
Copy link
Member

davkean commented Aug 18, 2016

  1. Create a new project with Class1.cs
  2. Create a new folder called "Bar"
  3. Drag Class1.cs into "Bar"

Expected: No prompt for rename
Actual: Prompt for rename

@davkean davkean added the Bug label Aug 18, 2016
@davkean davkean added this to the 1.0 Preview 5 - 1 milestone Aug 18, 2016
@davkean
Copy link
Member Author

davkean commented Aug 18, 2016

tag @jinujoseph

@srivatsn srivatsn modified the milestones: 1.0 Preview 5 - 1, 1.0 Preview 5 Aug 22, 2016
@srivatsn srivatsn modified the milestones: 1.0 Preview 5 - 2 , 1.0 Preview 5 Sep 16, 2016
@srivatsn srivatsn modified the milestones: 1.0 Preview 5, 1.0 RC, 1.0 RC3, 1.0 RC2 Nov 3, 2016
@srivatsn
Copy link
Contributor

@jinujoseph is this fixed - I remember some change around this.

@jinujoseph
Copy link
Contributor

nope , this does repro in d15rel/15.0.2006.2

@333fred
Copy link
Member

333fred commented Dec 23, 2016

One question I have on this: do we want to do namespace renames? If we move a file from a path that is a valid namespace to a path that is a valid namespace, it seems reasonable that we should prompt to move the namespace the contained class is in.

@davkean
Copy link
Member Author

davkean commented Dec 23, 2016

Move or sync it? My opinion is that I don't think we should ever prompt - we should just add an undo unit so that the user can undo the rename, ie I'm thinking like the "Copy Code -> Paste -> Auto format" behavior we have in Roslyn.

@333fred
Copy link
Member

333fred commented Dec 23, 2016

Filled #1035 for that idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants