Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PackageReference items that come from package's targets files should not be included in the set we push to NuGet #3734

Open
davkean opened this issue Jul 17, 2018 · 1 comment
Open

PackageReference items that come from package's targets files should not be included in the set we push to NuGet #3734

davkean opened this issue Jul 17, 2018 · 1 comment
Labels
Feature-NuGet NuGet integration including pushing it properties, project and package references, and Pack support. Triage-Investigate Reviewed and investigation needed by dev team
Milestone
Backlog

Comments

@davkean
Copy link
Member

davkean commented Jul 17, 2018 •
edited
Loading

Command-line restore will not import package reference's target files during restore phase (via ExcludeRestorePackageImports), but due to VS's single evaluation model we'll include any PackageReference items that are present when we push packages to NuGet. We should deliberately filter package references out that come from package targets to have the same behavior as command-line restore.
@Pilchie Pilchie added Feature-NuGet NuGet integration including pushing it properties, project and package references, and Pack support. Project-System-CPS labels Jul 17, 2018
@Pilchie Pilchie added this to the 16.0 milestone Jul 17, 2018
@jjmew jjmew modified the milestones: 16.0, 16.X Feb 13, 2019
@nkolev92 nkolev92 mentioned this issue Jul 10, 2019
Closed
@davkean davkean added the Bug label Jan 27, 2020
@davkean davkean added this to the Backlog milestone Jan 27, 2020
@davkean davkean added the Triage-Investigate Reviewed and investigation needed by dev team label Jan 27, 2020
@davkean
Copy link
Member Author

davkean commented Jan 27, 2020

We should consider adding a warning for this if we encounter this.

@nkolev92 nkolev92 mentioned this issue Feb 4, 2020
Closed
@cmenzi cmenzi mentioned this issue Feb 5, 2020
Closed
@nkolev92 nkolev92 mentioned this issue Aug 23, 2022
Open
@drewnoakes drewnoakes removed the Bug label Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature-NuGet NuGet integration including pushing it properties, project and package references, and Pack support. Triage-Investigate Reviewed and investigation needed by dev team
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
5 participants
@Pilchie @drewnoakes @davkean @jmarolf @jjmew