Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New ProjectSystem shim the IVsHierarchy in Roslyn workspace, and break extensions to match projects #3796

Closed
lifengl opened this issue Jul 27, 2018 · 2 comments
Closed

New ProjectSystem shim the IVsHierarchy in Roslyn workspace, and break extensions to match projects #3796

lifengl opened this issue Jul 27, 2018 · 2 comments
Assignees
@davkean
Labels
Feature-Language-Service Populating the Roslyn workspace with references, source files, analyzers, etc Feature-XAML Features related to the XAML designer and display and manipulation of XAML files. Resolution-Fixed The bug has been fixed, refer to the milestone to see in which release it was fixed.
Milestone
16.0 Preview 2

Comments

@lifengl
Copy link
Contributor

lifengl commented Jul 27, 2018

XAML code generator try to find Roslyn project based on IVsHierarchy and failed to do so. This can break other 2nd party code.
@davkean davkean added Feature-Language-Service Populating the Roslyn workspace with references, source files, analyzers, etc Feature-XAML Features related to the XAML designer and display and manipulation of XAML files. labels Jul 27, 2018
@davkean davkean self-assigned this Jul 27, 2018
@davkean davkean added the Bug label Jul 27, 2018
@davkean davkean added this to the 15.9 milestone Jul 27, 2018
@davkean
Copy link
Member

davkean commented Jul 27, 2018

This blocks XAML.

@Pilchie Pilchie modified the milestones: 15.9, 16.0 Nov 15, 2018
@jjmew jjmew modified the milestones: 16.0, 16.1 Dec 18, 2018
@davkean davkean modified the milestones: 16.1, 16.0 Preview 2 Jan 16, 2019
@davkean
Copy link
Member

davkean commented Jan 16, 2019

This has been fixed in #4419.

@davkean davkean closed this as completed Jan 16, 2019
@davkean davkean added the Resolution-Fixed The bug has been fixed, refer to the milestone to see in which release it was fixed. label Jan 16, 2019
@drewnoakes drewnoakes removed the Bug label Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davkean davkean

Labels
Feature-Language-Service Populating the Roslyn workspace with references, source files, analyzers, etc Feature-XAML Features related to the XAML designer and display and manipulation of XAML files. Resolution-Fixed The bug has been fixed, refer to the milestone to see in which release it was fixed.
Projects
None yet
Milestone
16.0 Preview 2
Development

No branches or pull requests
5 participants
@Pilchie @drewnoakes @davkean @lifengl @jjmew