Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

High-priority list of properties requiring attention (3) #6989

Closed
6 tasks done
tmeschter opened this issue Feb 25, 2021 · 5 comments · Fixed by #7362
Closed
6 tasks done

High-priority list of properties requiring attention (3) #6989

tmeschter opened this issue Feb 25, 2021 · 5 comments · Fixed by #7362
Assignees
Labels
Feature-Project-Properties-Designer The new project property pages which replace the legacy AppDesigner Must-Have Items that must be delivered by the end of the assigned milestone Resolution-Fixed The bug has been fixed, refer to the milestone to see in which release it was fixed. Triage-Approved Reviewed and prioritized
Milestone

Comments

@tmeschter
Copy link
Contributor

tmeschter commented Feb 25, 2021

This work item has been split off of #6907 to contain the highest priority items.

The following properties are currently included in the UI and require some sort of additional treatment to make them work correctly.

  • Order of values in target framework drop down (both .NET Core and .NET Framework families) (possibly CPS, maybe this)
    • This may be a bug in our SupportedTargetFrameworksProvider; we may need to do some explicit sorting.
  • Nullable should only be visible when using C# 8 or greater
    • Possible solution: expose the language version as a hidden property, and condition the visibility of Nullable on that.
  • Nullable appearing with nothing selected Opened Determine general solution for properties that have no initial value #7360
    • This is because the SDK doesn't provide a default value for the <Nullable> property. We don't currently have a good general solution to this, but it could be handled with an IInterceptingPropertyValueProvider: if the property isn't set it could return disabled for the value.
  • Toggling "use multi-targeting" shows a project fault (fix or remove these options)
    • We should remove the check box, and condition the visibility of the TargetFramework and TargetFrameworks properties on those properties actually being defined. That way only one or the other will show.
  • Rationalize TreatWarningsAsErrors, NoWarn, WarningsAsErrors and WarningsNotAsErrors (see Add UI for WarningsNotAsErrors #2409 for some context)
    • These properties are all related, so we should make sure the user understands how they work together.
  • "Prefer 32-bit" should show, but only when targeting .NET Framework (PR Add Prefer32Bit property #7362)
    • When single-targeting we should show this if the target framework is from the .NET Framework family.
    • When multi-targeting, we should show this if any of the target frameworks is from the .NET Framework family.
@tmeschter tmeschter added the Feature-Project-Properties-Designer The new project property pages which replace the legacy AppDesigner label Feb 25, 2021
@tmeschter tmeschter added this to the 16.10 milestone Feb 25, 2021
@tmeschter
Copy link
Contributor Author

@jjmew Here's the issue tracking the property page tweaks that I think someone other than me or @drewnoakes could make. I've excluded items that I view as low priority (e.g., changes specifically to support non-SDK projects) or are complex.

@drewnoakes I split these out of #6907. Let me know if there are other things we could include here.

@drewnoakes
Copy link
Member

@tmeschter @jjmew I think it would be easier to track if these were broken out into separate issues. Priorities can be fluid, and these may be assigned to different people.

@jjmew jjmew added the Triage-Approved Reviewed and prioritized label Feb 26, 2021
@tmeschter
Copy link
Contributor Author

@drewnoakes Per @jjmew's request, I've kept these in a single issue.

@jjmew
Copy link
Contributor

jjmew commented Feb 26, 2021

@drewnoakes the reason was because I could assign it directly to @MiYanni

@melytc melytc added the Must-Have Items that must be delivered by the end of the assigned milestone label May 17, 2021
@drewnoakes drewnoakes changed the title High-priority list of properties requiring attention High-priority list of properties requiring attention (2) May 18, 2021
@drewnoakes drewnoakes changed the title High-priority list of properties requiring attention (2) High-priority list of properties requiring attention (3) May 18, 2021
@drewnoakes drewnoakes modified the milestones: 16.10, 17.0 Jun 5, 2021
@ghost ghost added the Resolution-Fixed The bug has been fixed, refer to the milestone to see in which release it was fixed. label Jun 28, 2021
@MiYanni
Copy link
Member

MiYanni commented Jun 29, 2021

All of these have either been addressed or split into other issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature-Project-Properties-Designer The new project property pages which replace the legacy AppDesigner Must-Have Items that must be delivered by the end of the assigned milestone Resolution-Fixed The bug has been fixed, refer to the milestone to see in which release it was fixed. Triage-Approved Reviewed and prioritized
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants