Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Program Icon property must copy .ico file to project (2) #7167

Closed
sujitnayak opened this issue Apr 30, 2021 · 2 comments · Fixed by #7461
Closed

Program Icon property must copy .ico file to project (2) #7167

sujitnayak opened this issue Apr 30, 2021 · 2 comments · Fixed by #7461
Assignees
Labels
Feature-Project-Properties-Designer The new project property pages which replace the legacy AppDesigner Must-Have Items that must be delivered by the end of the assigned milestone Resolution-Fixed The bug has been fixed, refer to the milestone to see in which release it was fixed. Triage-Approved Reviewed and prioritized
Milestone

Comments

@sujitnayak
Copy link

sujitnayak commented Apr 30, 2021

Visual Studio Version: 16.10 P3 Main builds (31229.188.main on my machine)

Summary:
Adding program icon with new Project Properties UX has a different behavior than the previous UX as described in Actual Behavior section.

Steps to Reproduce:

  1. Create WPF or Winforms project for .NET Core/.NET FX 5.0

  2. Go to Project Properties -> Application -> Resources tab and add program icon.

Expected Behavior:
The .ico file gets copied to the project directory and ApplicationIcon property is written to project file with just the name of the .ico file

Actual Behavior:
The icon file does not get copied to project folder and the ApplicationIcon property written to project file is fully qualified path to the .ico file.

User Impact:
ClickOnce publish fails due to this breaking change as it expects the .ico file to be in the project directory.

@drewnoakes drewnoakes added the Feature-Project-Properties-Designer The new project property pages which replace the legacy AppDesigner label May 3, 2021
@jjmew jjmew added the Bug label May 4, 2021
@jjmew jjmew assigned tmeschter and melytc and unassigned tmeschter May 4, 2021
@jjmew jjmew added this to the 17.0 milestone May 4, 2021
@jjmew jjmew added the Triage-Approved Reviewed and prioritized label May 4, 2021
@melytc melytc added the Must-Have Items that must be delivered by the end of the assigned milestone label May 17, 2021
@melytc
Copy link
Contributor

melytc commented May 20, 2021

For reference, this is the previous experience looks like:
image

And this is the new experience:
image

@melytc melytc changed the title Adding Program Icon with new Project Properties UX has different behavior compared to old UX Adding Program Icon with new Project Properties UX has different behavior compared to old UX. (2) May 20, 2021
@drewnoakes
Copy link
Member

See also #6457 for a very similar work item on a different property. I suspect the solution to each will look similar.

@drewnoakes drewnoakes changed the title Adding Program Icon with new Project Properties UX has different behavior compared to old UX. (2) Program Icon property must copy .ico file to project (2) Jul 1, 2021
@MiYanni MiYanni assigned MiYanni and unassigned melytc Jul 26, 2021
@ghost ghost added the Resolution-Fixed The bug has been fixed, refer to the milestone to see in which release it was fixed. label Aug 18, 2021
@drewnoakes drewnoakes removed the Bug label Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature-Project-Properties-Designer The new project property pages which replace the legacy AppDesigner Must-Have Items that must be delivered by the end of the assigned milestone Resolution-Fixed The bug has been fixed, refer to the milestone to see in which release it was fixed. Triage-Approved Reviewed and prioritized
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants