Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove hardcoded map values s_packageVersionToComponentId #8186

Open
ocallesp opened this issue May 18, 2022 · 0 comments
Open

Remove hardcoded map values s_packageVersionToComponentId #8186

ocallesp opened this issue May 18, 2022 · 0 comments
Labels
Feature-Acquisition In-Product Acquisition (IPA), to detect and prompt to install of components and workloads via setup Triage-Approved Reviewed and prioritized
Milestone
Backlog

Comments

@ocallesp
Copy link
Contributor

ocallesp commented May 18, 2022 •
edited
Loading

We have to improve the design MissingRuntime to be less fragile whenever Msft adds new runtime versions.

We have to remove the hardcoded map s_packageVersionToComponentId that contains the relation (RuntimeVersion, ComponentId).

Since Sdk manages this information (runtime versions and component Ids), we have created the GitHub #25575 to request a new design-time msbuild item that can provide the componentId of a missing runtime.

Once #25575 is completed, we have to update the design of MissingSdkRuntimeDetector to read the componentId from the new design-time msbuild item.
@ocallesp ocallesp mentioned this issue May 18, 2022
Merged
@ocallesp ocallesp self-assigned this May 18, 2022
@kvenkatrajan kvenkatrajan added this to the Backlog milestone May 19, 2022
@kvenkatrajan kvenkatrajan added the Triage-Approved Reviewed and prioritized label May 19, 2022
@ocallesp ocallesp mentioned this issue May 21, 2022
Open
@drewnoakes drewnoakes added the Feature-Acquisition In-Product Acquisition (IPA), to detect and prompt to install of components and workloads via setup label Sep 12, 2023
This was referenced Oct 7, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature-Acquisition In-Product Acquisition (IPA), to detect and prompt to install of components and workloads via setup Triage-Approved Reviewed and prioritized
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
3 participants
@drewnoakes @ocallesp @kvenkatrajan