Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How do I build the Repository does not mention npm. #9642

Open
dhoehna opened this issue Jan 30, 2025 · 5 comments
Open

How do I build the Repository does not mention npm. #9642

dhoehna opened this issue Jan 30, 2025 · 5 comments

Comments

@dhoehna
Copy link
Contributor

dhoehna commented Jan 30, 2025

Visual Studio Version

N/A

Summary

How do I build this Repository neglects telling developers that npm is required.

Steps to Reproduce

  1. Make sure npm is not installed
  2. run build.cmd
  3. The build will fail when running the command npm version...

Expected Behavior

Documentation mentions having npm installed.

Actual Behavior

build.cmd fails.

User Impact

@drewnoakes
Copy link
Member

I'm surprised that npm is required, and I can't see how it would be called from our build scripts. Can you tell what's calling it, from the console output? I don't want to uninstall NPM to try this :)

I see references to it in our YAML files, but they're only used in CI pipelines on Azure DevOps afaik.

@dhoehna
Copy link
Contributor Author

dhoehna commented Feb 5, 2025

%USER%.nuget\packages\microsoft.visualstudio.internal.microbuild.npmpack\2.0.117\build\Microsoft.VisualStudio.Internal.MicroBuild.NpmPack.targets(66,5): error MSB3073: The command "npm version 99.0.0-dev" exited with code 9009. is the output from build.cmd

Specifically line 66

@dhoehna
Copy link
Contributor Author

dhoehna commented Feb 5, 2025

Doing some more digging the change was added ~3 years ago

@dhoehna
Copy link
Contributor Author

dhoehna commented Feb 5, 2025

I have a formed branch with the change to README.md that adds NPM as a necessary component. I can make a PR after #9643 is merged.

@adamint
Copy link
Member

adamint commented Feb 10, 2025

Hi @dhoehna, NPM is not required to build the repository. It however is required when publishing, as we do create NPM packages. Can you explain what you were doing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants