Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert TargetPath encoding workaround after fix in Roslyn #7566

Open
captainsafia opened this issue Apr 15, 2021 · 3 comments
Open

Revert TargetPath encoding workaround after fix in Roslyn #7566

captainsafia opened this issue Apr 15, 2021 · 3 comments
Labels
area-compiler Umbrella for all compiler issues task untriaged

Comments

@captainsafia
Copy link
Member

We put in a workaround in dotnet/sdk#16858 to make sure that the Razor source generator works correctly when there is a special character in the filename.

We should remove this once this is fixed more permanently in Roslyn. See dotnet/roslyn#51692.

@captainsafia captainsafia added task area-compiler Umbrella for all compiler issues labels Apr 15, 2021
@ghost
Copy link

ghost commented Apr 15, 2021

Thanks for contacting us.
We're moving this issue to the Next sprint planning milestone for future evaluation / consideration. Because it's not immediately obvious that this is a bug in our framework, we would like to keep this around to collect more feedback, which can later help us determine the impact of it. We will re-evaluate this issue, during our next planning meeting(s).
If we later determine, that the issue has no community involvement, or it's very rare and low-impact issue, we will close it - so that the team can focus on more important and high impact issues.
To learn more about what to expect next and how this issue will be handled you can read more about our triage process here.

@ghost
Copy link

ghost commented Oct 21, 2021

We've moved this issue to the Backlog milestone. This means that it is not going to be worked on for the coming release. We will reassess the backlog following the current release and consider this item at that time. To learn more about our issue management process and to have better expectation regarding different types of issues you can read our Triage Process.

@captainsafia
Copy link
Member Author

FWIW, this is now fixed in Roslyn and the revert needs to be applied.

@mkArtakMSFT mkArtakMSFT transferred this issue from dotnet/aspnetcore Apr 12, 2022
@chsienki chsienki transferred this issue from dotnet/razor-compiler Oct 28, 2022
@ghost ghost added the untriaged label Oct 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-compiler Umbrella for all compiler issues task untriaged
Projects
None yet
Development

No branches or pull requests

1 participant