Update CA1822 for Primary Constructor Parameters

[333fred]

Analyzer

Diagnostic ID: CA1822: Mark members as static

Analyzer source

SDK: Built-in CA analyzers in .NET 8p6 SDK or later

Version: SDK 8.0.0-preview6

Describe the bug

CA1822 needs to be updated to include referencing primary constructor parameters as accessing "instance" state. Right now, it suggests marking members that only access PC parameters as static, which is incorrect. See the screenshots reported here: dotnet/csharplang#7377 (reply in thread)

Steps To Reproduce

1. Create a new project with .NET 8 and enable analysis.
2. Create a type with a primary constructor.
3. Try one of the code samples in the linked comment, such as having an expression-bodied property return a PC parameter.

Expected behavior

No warnings.

Actual behavior

CA1822 is issued.

Additional context

This is a C# 12 feature, may require updating the roslyn reference in tests to use.

[mavasani]

Duplicate of #6573