Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that all binding in semantic models is subject to rewriting #35038

Open
333fred opened this issue Apr 17, 2019 · 2 comments
Open

Ensure that all binding in semantic models is subject to rewriting #35038

333fred opened this issue Apr 17, 2019 · 2 comments
Labels
Area-Compilers Bug Feature - Nullable Reference Types Nullable Reference Types Feature - Nullable Semantic Model Nullable Semantic Model Issues
Milestone
Backlog

Comments

@333fred
Copy link
Member

333fred commented Apr 17, 2019

There are several sections of code that currently are not having rewriting done, and they probably should. We need to come up with test cases that will expose the lack of rewriting and then implement the rewriting sections.
@333fred
Copy link
Member Author

333fred commented Apr 17, 2019

In particular, look at unbound lambdas and ensure that we are recording the results of rewriting the bodies appropriately.

@gafter gafter added this to the Compiler.Next milestone Aug 27, 2019
@gafter gafter added the Feature - Nullable Reference Types Nullable Reference Types label Sep 12, 2019
@333fred
Copy link
Member Author

333fred commented Jun 23, 2020

Additionally GetSpeculativeSymbolInfo(int position, ConstructorInitializerSyntax constructorInitializer) and GetSpeculativeSymbolInfo(int position, PrimaryConstructorBaseTypeSyntax constructorInitializer).

@jaredpar jaredpar modified the milestones: Compiler.Next, Backlog Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Compilers Bug Feature - Nullable Reference Types Nullable Reference Types Feature - Nullable Semantic Model Nullable Semantic Model Issues
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
3 participants
@jaredpar @333fred @gafter