Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Follow-up to PR "Create default arguments during binding" #49559

Closed
RikkiGibson opened this issue Nov 22, 2020 · 0 comments · Fixed by #49588
Closed

Follow-up to PR "Create default arguments during binding" #49559

RikkiGibson opened this issue Nov 22, 2020 · 0 comments · Fixed by #49588
Assignees
@RikkiGibson
Labels
Area-Compilers Bug
Milestone
16.9

Comments

@RikkiGibson
Copy link
Contributor

RikkiGibson commented Nov 22, 2020 •
edited
Loading

We need to pick a much higher number here. It is more than reasonable for a thread to hang for 5 secnds in CI

Originally posted by @jaredpar in #49186 (comment)

Feel like ForceComplete should change to assert that this part has completed. That is the pattern we usually have elsewhere.

Originally posted by @jaredpar in #49186 (comment)

Should use callerSourceLocation here instead of GetCallerLocation here

Originally posted by @RikkiGibson in #49186 (comment)
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added Area-Infrastructure untriaged Issues and PRs which have not yet been triaged by a lead labels Nov 22, 2020
@RikkiGibson RikkiGibson self-assigned this Nov 22, 2020
@RikkiGibson RikkiGibson changed the title Follow-up to PR #49186 Follow-up to PR "Create default arguments during binding" Nov 22, 2020
@jaredpar jaredpar added Bug and removed untriaged Issues and PRs which have not yet been triaged by a lead labels Nov 23, 2020
@jaredpar jaredpar added this to the 16.9 milestone Nov 23, 2020
@RikkiGibson RikkiGibson mentioned this issue Nov 24, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RikkiGibson RikkiGibson

Labels
Area-Compilers Bug
Projects
None yet
Milestone
16.9
Development

Successfully merging a pull request may close this issue.

Resolve follow-up comments in PR "Create default arguments during binding" RikkiGibson/roslyn
3 participants
@jaredpar @RikkiGibson @Dotnet-GitSync-Bot