Verify accuracy of TupleElementNames tests for Implement Interface

[sharwell]

Can someone from the @dotnet/roslyn-compiler team verify that we are testing Implement Interface with an accurate representation of TupleElementNames metadata?

roslyn/src/EditorFeatures/CSharpTest/ImplementInterface/ImplementInterfaceTests.cs

Lines 289 to 316 in 51c367a

	[Fact, Trait(Traits.Feature, Traits.Features.CodeActionsImplementInterface), CompilerTrait(CompilerFeature.Tuples)]
	public async Task TupleWithNamesInMethod()
	{
	// Note: we're putting the attribute by hand to simulate metadata
	await TestWithAllCodeStyleOptionsOffAsync(
	@"interface IInterface
	{
	[return: {|CS8138:System.Runtime.CompilerServices.TupleElementNames(new[] { ""a"", ""b"" })|}]
	(int a, int b)[] Method1((int c, string) x);
	}
	class Class : {|CS0535:IInterface|}
	{
	}",
	@"interface IInterface
	{
	[return: {|CS8138:System.Runtime.CompilerServices.TupleElementNames(new[] { ""a"", ""b"" })|}]
	(int a, int b)[] Method1((int c, string) x);
	}
	class Class : IInterface
	{
	public (int a, int b)[] Method1((int c, string) x)
	{
	throw new System.NotImplementedException();
	}
	}");
	}

💭 It seems like if we apply TupleElementNames manually, the test should be written with ValueTuple<int, int> syntax instead of (int a, int b) syntax.

🔗 Observed during review in #54310 (comment)

[Youssef1313]

@sharwell Is Area-Compilers intentional here? I interpret the issue as a problem in IDE test.

[sharwell]

Yes, this one is a verification request for the compiler team (to make sure we are testing the correct thing).

[jaredpar]

It seems like if we apply TupleElementNames manually, the test should be written with ValueTuple<int, int> syntax instead of (int a, int b) syntax.

I'm not sure what the ask is here. Both of these are cases that the compiler needs to understand (users can legally do both so we have to have a response to each of the scenarios). It depends on what the IDE intent is here and what scenario you are trying to exercise.

@jcouv

[CyrusNajmabadi]

I don't think there's any compiler info needed here. This is also not a priority scenario for IDE if a user manually supplies these attributes.