Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect SyntaxNode generation for Implement Interface code fix #54329

Closed
sharwell opened this issue Jun 23, 2021 · 1 comment
Closed

Fix incorrect SyntaxNode generation for Implement Interface code fix #54329

sharwell opened this issue Jun 23, 2021 · 1 comment
Labels
Area-IDE Concept-Continuous Improvement help wanted The issue is "up for grabs" - add a comment if you are interested in working on it IDE-CodeStyle Built-in analyzers, fixes, and refactorings
Milestone
Backlog

Comments

@sharwell
Copy link
Member

Several tests for Implement Interface use CodeActionValidationMode.None due to mismatched SyntaxNode generation. These should be reviewed and corrected to produce the expected nodes.
@sharwell sharwell added help wanted The issue is "up for grabs" - add a comment if you are interested in working on it Area-IDE Concept-Continuous Improvement IDE-CodeStyle Built-in analyzers, fixes, and refactorings labels Jun 23, 2021
@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged Issues and PRs which have not yet been triaged by a lead label Jun 23, 2021
@sharwell sharwell mentioned this issue Jun 23, 2021
Merged
@jinujoseph jinujoseph removed the untriaged Issues and PRs which have not yet been triaged by a lead label Jun 25, 2021
@jinujoseph jinujoseph added this to the Backlog milestone Jun 25, 2021
@CyrusNajmabadi
Copy link
Member

Closing out as speculative. If we need to do this we should assing a person/milestone and get it done.

@CyrusNajmabadi CyrusNajmabadi closed this as not planned Won't fix, can't repro, duplicate, stale Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-IDE Concept-Continuous Improvement help wanted The issue is "up for grabs" - add a comment if you are interested in working on it IDE-CodeStyle Built-in analyzers, fixes, and refactorings
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
3 participants
@sharwell @CyrusNajmabadi @jinujoseph