-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TestTypeAliases tests are failing in roslyn-ci main #68312
Comments
Here are logs of the failing tests in job Test Windows CoreClr Debug Single Machine. Note that this test only runs on rolling builds, which is why it isn't blocking PRs. Test log
It seems like some aliases which were expected to be included in the PDB are no longer being included. @CyrusNajmabadi it looks like you may have updated the affected tests most recently. Any insight into what may be happening?
|
This runs on PRs. Example is this AzDO build. You can see by setting the filters. This specific configuration though is CI only. Basically when we build and test on the same machine (no helix). That is very odd that it's failing only in that configuration and not in the Helix one. |
Good news though is @CyrusNajmabadi should be able to reproduce this locally 😄 |
I said test when I meant to say job, sorry. |
In chatting with @CyrusNajmabadi my suspicion would be on #67105 |
I'd be fine if we remove testing of Windows PDBs for this feature (which is likely causing the non-deterministic behavior). |
Assigning to @jaredpar just because he's already got a PR out for it. |
I don't have a PR out to fix this. Only thing I have out is about Macs. @CyrusNajmabadi has one out that disables the tests but doesn't fix the underlying issue. This is a product bug, not a test issue by all the evidence we see. This seemingly dates back to #25737 (thanks @CyrusNajmabadi for tracking that down). If it is a Windows PDB issue we should be filing a bug on the Windows DIA layer and adjusting our tests to not test using native PDBs. Just ignoring it doesn't seem like the right thing. |
@jaredpar: oops, my bad. |
Runfo Tracking Issue: TestTypeAliases tests are failing in roslyn-ci main
Build Result Summary
The text was updated successfully, but these errors were encountered: