Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generated field is not working well since the last update #68322

Closed
vsfeedback opened this issue May 25, 2023 · 4 comments · Fixed by #68325
Closed

Generated field is not working well since the last update #68322

vsfeedback opened this issue May 25, 2023 · 4 comments · Fixed by #68325
Labels
Area-IDE Bug

Comments

@vsfeedback
Copy link

This issue has been moved from a ticket on Developer Community.

[severity:It's more difficult to complete my work] [regression] [worked-in:17.5.4]
Generated field is not working well since the last update. It's not taking the proper type, it's outputting everything to object

Original Comments

Feedback Bot on 5/24/2023, 09:26 PM:

(private comment, text removed)

Original Solutions

(no solutions)
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels May 25, 2023
@CyrusNajmabadi
Copy link
Member

I don't repro this. Generate-field seems to work fine for me. Can you provide a repro case where it doesn't?

@CyrusNajmabadi CyrusNajmabadi added Need More Info The issue needs more information to proceed. and removed untriaged Issues and PRs which have not yet been triaged by a lead labels May 25, 2023
@Metalfution
Copy link

The problem occurs when you want to generate fields by the constructor parameters. I attach photos so you understand my explanation
![1](https://github.com/dot
2
net/roslyn/assets/80608745/af235
3
938-fbc2-4dce-930d-baee77c508c3)

@ghost ghost added untriaged Issues and PRs which have not yet been triaged by a lead and removed Need More Info The issue needs more information to proceed. labels May 25, 2023
@Metalfution
Copy link

I just did another test and the error occurs when the class is instantiated only with new, when the class is explicitly instantiated using new and the class does not occur.

1
2

@CyrusNajmabadi
Copy link
Member

Ok. So this is about generate-field working well with implicit-object-creation. Thanks! :)

@CyrusNajmabadi CyrusNajmabadi mentioned this issue May 25, 2023
Merged
@CyrusNajmabadi CyrusNajmabadi added Bug and removed untriaged Issues and PRs which have not yet been triaged by a lead labels May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-IDE Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make 'generate field' work better with implicit object creation CyrusNajmabadi/roslyn
3 participants
@CyrusNajmabadi @vsfeedback @Metalfution