Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Style: Roslyn Workspace APIs need to support per-file options #7058

Closed
Pilchie opened this issue Nov 25, 2015 · 6 comments
Closed

Code Style: Roslyn Workspace APIs need to support per-file options #7058

Pilchie opened this issue Nov 25, 2015 · 6 comments

Comments

@Pilchie
Copy link
Member

Pilchie commented Nov 25, 2015

No description provided.

@sharwell
Copy link
Member

In case anyone is wondering why - this would allow things like automatic detection of spaces vs. tabs and/or indentation size when editing a file, rather than just always assuming that every file should use the settings of the current project.

@paul1956
Copy link
Contributor

@sharwell I am confused by what behaviour you want. What I think addresses working on a project with multiple people or in my case with different editors, is for a setting that fixed the things you describe automatically according to a file or project setting. I hate when Visual Studio constantly asked me if I want to convert tabs only to have something else convert it back.

@sharwell
Copy link
Member

I am confused by what behaviour you want.

I tried to emphasize allow in my comment. I was merely giving an example of something new you could do if options could be per-file instead of per-project. I edited my comment to hopefully avoid misleading readers.

@Pilchie
Copy link
Member Author

Pilchie commented Nov 25, 2015

Automatic detection is something we would like to do, but we would probably do it as a way to set the settings initially.

This will be necessary if we want to support .editorconfig, since you could have a pattern for specific file names.

@DustinCampbell DustinCampbell modified the milestones: 2.0, 1.2 Feb 5, 2016
@mkrueger
Copy link
Contributor

Having a more fine grained optionset handling would be awesome. We in XS have options on project level so it would be really helpful if that would be changed.

@DustinCampbell DustinCampbell modified the milestones: 2.0 (Preview), 2.0 (RC) Mar 9, 2016
@gafter gafter modified the milestones: 2.0 (Preview 3), 2.0 (RC) Jul 14, 2016
@Pilchie Pilchie modified the milestones: 2.0 (Preview 5), 2.0 (RC) Sep 26, 2016
@Pilchie
Copy link
Member Author

Pilchie commented Nov 2, 2016

This is done, right @jasonmalinowski ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants