Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EditorConfig parsing doesn't match spec #71727

Open
ToddGrun opened this issue Jan 19, 2024 · 0 comments
Open

EditorConfig parsing doesn't match spec #71727

ToddGrun opened this issue Jan 19, 2024 · 0 comments

Comments

@ToddGrun
Copy link
Contributor

ToddGrun commented Jan 19, 2024

  1. Per spec, the key can contain non-prefix and non-suffix spaces. Roslyn doesn't appear to allow this.
  2. Per spec, key and value are separated by '='. Roslyn appears to allow an ':' to also separate the key and value.

Both of these issues are in relation to the regex here.

Potential regex string

"^\s*([\w\.\-_]+(?:\s+[\w\.\-_]+)*)\s*=\s*(.*?)\s*$"
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead labels Jan 19, 2024
@ToddGrun ToddGrun added this to the 17.10 milestone Jan 19, 2024
@ToddGrun ToddGrun changed the title EditConfig parsing doesn't match spec EditorConfig parsing doesn't match spec Jan 19, 2024
@jaredpar jaredpar modified the milestones: 17.10, Backlog Jan 26, 2024
@jcouv jcouv removed the untriaged Issues and PRs which have not yet been triaged by a lead label Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants