Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renaming type parameters is broken in top-level methods and local functions #76650

Closed
jnm2 opened this issue Jan 7, 2025 · 0 comments · Fixed by #76652
Closed

Renaming type parameters is broken in top-level methods and local functions #76650

jnm2 opened this issue Jan 7, 2025 · 0 comments · Fixed by #76652
Assignees
@CyrusNajmabadi
Labels
Area-IDE Bug Feature - Rename help wanted The issue is "up for grabs" - add a comment if you are interested in working on it
Milestone
Backlog

Comments

@jnm2
Copy link
Contributor

jnm2 commented Jan 7, 2025

Version Used: 17.13.0 Preview 2.1

Rename any of the occurrences of T in:

T TopLevelMethod<T>() where T : new()
{
    return new T();
}

Image

Something similar is broken with local functions:

Image

In both cases, Find All References fails to find the instances that are failing to be renamed.
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead labels Jan 7, 2025
@CyrusNajmabadi CyrusNajmabadi mentioned this issue Jan 7, 2025
Merged
@CyrusNajmabadi CyrusNajmabadi self-assigned this Jan 7, 2025
@CyrusNajmabadi CyrusNajmabadi added Bug help wanted The issue is "up for grabs" - add a comment if you are interested in working on it Area-IDE Feature - Rename and removed Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead labels Jan 7, 2025
@CyrusNajmabadi CyrusNajmabadi added this to the Backlog milestone Jan 7, 2025
@github-project-automation github-project-automation bot moved this to InQueue in Small Fixes Jan 7, 2025
@github-project-automation github-project-automation bot moved this from InQueue to Completed in Small Fixes Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CyrusNajmabadi CyrusNajmabadi

Labels
Area-IDE Bug Feature - Rename help wanted The issue is "up for grabs" - add a comment if you are interested in working on it
Projects
Small Fixes
Status: Completed
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

Fix FAR/rename with method type parameters CyrusNajmabadi/roslyn
2 participants
@CyrusNajmabadi @jnm2