From 35f281bc4f6b1d17fe4620828ed8ad74d6003976 Mon Sep 17 00:00:00 2001 From: giritrivedi Date: Wed, 9 Oct 2024 08:51:50 +0200 Subject: [PATCH 1/3] Fix endianness issues to fix failures in Emit testsuite --- src/Compilers/Test/Core/Metadata/DynamicAnalysisDataReader.cs | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/Compilers/Test/Core/Metadata/DynamicAnalysisDataReader.cs b/src/Compilers/Test/Core/Metadata/DynamicAnalysisDataReader.cs index d1af24ac0fc60..d86fc15965679 100644 --- a/src/Compilers/Test/Core/Metadata/DynamicAnalysisDataReader.cs +++ b/src/Compilers/Test/Core/Metadata/DynamicAnalysisDataReader.cs @@ -179,7 +179,8 @@ public static DynamicAnalysisDataReader TryCreateFromPE(PEReader peReader, strin } byte* resourceStart = peImage.Pointer + start; - int resourceSize = *(int*)resourceStart; + BlobReader tmpresource = peImage.GetReader(start , peImage.Length-start); + int resourceSize = tmpresource.ReadInt32(); if (resourceSize > resourcesDir.Size - sizeof(int)) { throw new BadImageFormatException(); From 8f109c0ec830cb348443a8ee43728f6f2db07ea6 Mon Sep 17 00:00:00 2001 From: Giridhar Trivedi Date: Wed, 9 Oct 2024 15:54:46 +0530 Subject: [PATCH 2/3] Fix formatting error --- src/Compilers/Test/Core/Metadata/DynamicAnalysisDataReader.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Compilers/Test/Core/Metadata/DynamicAnalysisDataReader.cs b/src/Compilers/Test/Core/Metadata/DynamicAnalysisDataReader.cs index d86fc15965679..8b7f079473b33 100644 --- a/src/Compilers/Test/Core/Metadata/DynamicAnalysisDataReader.cs +++ b/src/Compilers/Test/Core/Metadata/DynamicAnalysisDataReader.cs @@ -179,7 +179,7 @@ public static DynamicAnalysisDataReader TryCreateFromPE(PEReader peReader, strin } byte* resourceStart = peImage.Pointer + start; - BlobReader tmpresource = peImage.GetReader(start , peImage.Length-start); + BlobReader tmpresource = peImage.GetReader(start, peImage.Length-start); int resourceSize = tmpresource.ReadInt32(); if (resourceSize > resourcesDir.Size - sizeof(int)) { From dc987148844695b798afb994fe4df0847f908d65 Mon Sep 17 00:00:00 2001 From: Giridhar Trivedi Date: Wed, 9 Oct 2024 16:24:32 +0530 Subject: [PATCH 3/3] Fix formating error DynamicAnalysisDataReader.cs --- src/Compilers/Test/Core/Metadata/DynamicAnalysisDataReader.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Compilers/Test/Core/Metadata/DynamicAnalysisDataReader.cs b/src/Compilers/Test/Core/Metadata/DynamicAnalysisDataReader.cs index 8b7f079473b33..0a4456d777acc 100644 --- a/src/Compilers/Test/Core/Metadata/DynamicAnalysisDataReader.cs +++ b/src/Compilers/Test/Core/Metadata/DynamicAnalysisDataReader.cs @@ -179,7 +179,7 @@ public static DynamicAnalysisDataReader TryCreateFromPE(PEReader peReader, strin } byte* resourceStart = peImage.Pointer + start; - BlobReader tmpresource = peImage.GetReader(start, peImage.Length-start); + BlobReader tmpresource = peImage.GetReader(start, peImage.Length - start); int resourceSize = tmpresource.ReadInt32(); if (resourceSize > resourcesDir.Size - sizeof(int)) {