From 0c40475c0545b38a128354caeb362d039b1cd31a Mon Sep 17 00:00:00 2001 From: Steve MacLean Date: Thu, 14 May 2020 21:20:44 -0400 Subject: [PATCH] Add missing issues.targets from #36253 (#36351) * Add missing issues.targets from #36253 PR #36253 enabled building all tests on OSX. It was intended to include this list of tests to disable on unsupported platforms. This was dropped as part of rebasing for dev/infra branch. Lack of CI on dev/infra allowed this to be missed. * Revise issues.targets * Add src/coreclr/tests/src/baseservices/typeequivalence/simple * Remove #if Windows from DllImportPathTest --- src/coreclr/tests/issues.targets | 955 ++++++++++++++++++ .../DllImportPath/DllImportPathTest.cs | 47 +- .../typeequivalence/TypeEquivalence.props | 8 - .../contracts/TypeContracts.csproj | 3 +- .../typeequivalence/impl/TypeImpl.csproj | 3 +- .../typeequivalence/simple/Simple.csproj | 3 +- 6 files changed, 994 insertions(+), 25 deletions(-) delete mode 100644 src/coreclr/tests/src/baseservices/typeequivalence/TypeEquivalence.props diff --git a/src/coreclr/tests/issues.targets b/src/coreclr/tests/issues.targets index 9b15770b27a97e..a04ba6b6652bce 100644 --- a/src/coreclr/tests/issues.targets +++ b/src/coreclr/tests/issues.targets @@ -1912,4 +1912,959 @@ + + + + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + + + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + + + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + + + + + CLRTestTargetUnsupported + + + + + + + CLRTestTargetUnsupported + + + + + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + + + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + + + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + + + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + + https://github.com/dotnet/runtime/issues/36404 + + + https://github.com/dotnet/runtime/issues/36404 + + + https://github.com/dotnet/runtime/issues/36404 + + + https://github.com/dotnet/runtime/issues/36404 + + + https://github.com/dotnet/runtime/issues/36404 + + + https://github.com/dotnet/runtime/issues/36404 + + + https://github.com/dotnet/runtime/issues/36404 + + + https://github.com/dotnet/runtime/issues/36404 + + + https://github.com/dotnet/runtime/issues/36404 + + + https://github.com/dotnet/runtime/issues/36404 + + + https://github.com/dotnet/runtime/issues/36404 + + + https://github.com/dotnet/runtime/issues/36404 + + + https://github.com/dotnet/runtime/issues/36404 + + + https://github.com/dotnet/runtime/issues/36404 + + + https://github.com/dotnet/runtime/issues/36404 + + + https://github.com/dotnet/runtime/issues/36404 + + + + + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + + CLRTestTargetUnsupported + + diff --git a/src/coreclr/tests/src/Interop/DllImportAttribute/DllImportPath/DllImportPathTest.cs b/src/coreclr/tests/src/Interop/DllImportAttribute/DllImportPath/DllImportPathTest.cs index 90e952b4496248..0771d8708cc8f7 100644 --- a/src/coreclr/tests/src/Interop/DllImportAttribute/DllImportPath/DllImportPathTest.cs +++ b/src/coreclr/tests/src/Interop/DllImportAttribute/DllImportPath/DllImportPathTest.cs @@ -13,13 +13,11 @@ class Test private const string PathEnvSubdirectoryName = "Subdirectory"; private const string PathEnvFileName = "MovedNativeLib"; -#if TARGET_WINDOWS - private const string RelativePath1 = @".\RelativeNative\..\DllImportPath_Relative"; - private const string RelativePath3 = @"..\DllImportPathTest\DllImportPath_Relative"; -#else - private const string RelativePath1 = @"./RelativeNative/../libDllImportPath_Relative"; - private const string RelativePath3 = @"../DllImportPathTest/libDllImportPath_Relative"; -#endif + private const string RelativePath1Windows = @".\RelativeNative\..\DllImportPath_Relative"; + private const string RelativePath3Windows = @"..\DllImportPathTest\DllImportPath_Relative"; + + private const string RelativePath1Unix = @"./RelativeNative/../libDllImportPath_Relative"; + private const string RelativePath3Unix = @"../DllImportPathTest/libDllImportPath_Relative"; private const string UnicodeFileName = "DllImportPath_Unicodeāœ”"; @@ -35,14 +33,20 @@ class Test [DllImport(@".\DllImportPath.Local.dll", EntryPoint = "GetZero")] private static extern int GetZero_LocalWithDot2(); - [DllImport(RelativePath1, EntryPoint = "GetZero")] - private static extern int GetZero_Relative1(); + [DllImport(RelativePath1Windows, EntryPoint = "GetZero")] + private static extern int GetZero_Relative1Windows(); + + [DllImport(RelativePath1Unix, EntryPoint = "GetZero")] + private static extern int GetZero_Relative1Unix(); [DllImport(@"..\DllImportPathTest\DllImportPath_Relative.dll", EntryPoint = "GetZero")] private static extern int GetZero_Relative2(); - [DllImport(RelativePath3, EntryPoint = "GetZero")] - private static extern int GetZero_Relative3(); + [DllImport(RelativePath3Windows, EntryPoint = "GetZero")] + private static extern int GetZero_Relative3Windows(); + + [DllImport(RelativePath3Unix, EntryPoint = "GetZero")] + private static extern int GetZero_Relative3Unix(); [DllImport(@".\..\DllImportPathTest\DllImportPath_Relative.dll", EntryPoint = "GetZero")] private static extern int GetZero_Relative4(); @@ -77,22 +81,37 @@ static void TestNativeLibraryProbingOnRelativePath() { string strManaged = "Managed"; string native = " Native"; + bool isWindows = RuntimeInformation.IsOSPlatform(OSPlatform.Windows); - if (!RuntimeInformation.IsOSPlatform(OSPlatform.Windows)) // We need to ensure that the subdirectory exists for off-Windows. + if (!isWindows) // We need to ensure that the subdirectory exists for off-Windows. { var currentDirectory = Directory.GetCurrentDirectory(); var info = new DirectoryInfo(currentDirectory); info.CreateSubdirectory(RelativeSubdirectoryName); } - GetZero_Relative1(); + if (isWindows) + { + GetZero_Relative1Windows(); + } + else + { + GetZero_Relative1Unix(); + } if (RuntimeInformation.IsOSPlatform(OSPlatform.Windows)) { GetZero_Relative2(); } - GetZero_Relative3(); + if (isWindows) + { + GetZero_Relative3Windows(); + } + else + { + GetZero_Relative3Unix(); + } if (RuntimeInformation.IsOSPlatform(OSPlatform.Windows)) { diff --git a/src/coreclr/tests/src/baseservices/typeequivalence/TypeEquivalence.props b/src/coreclr/tests/src/baseservices/typeequivalence/TypeEquivalence.props deleted file mode 100644 index 314431d8954f83..00000000000000 --- a/src/coreclr/tests/src/baseservices/typeequivalence/TypeEquivalence.props +++ /dev/null @@ -1,8 +0,0 @@ - - - - - true - - - diff --git a/src/coreclr/tests/src/baseservices/typeequivalence/contracts/TypeContracts.csproj b/src/coreclr/tests/src/baseservices/typeequivalence/contracts/TypeContracts.csproj index 81ee2a5675df36..ce626dfdd026ca 100644 --- a/src/coreclr/tests/src/baseservices/typeequivalence/contracts/TypeContracts.csproj +++ b/src/coreclr/tests/src/baseservices/typeequivalence/contracts/TypeContracts.csproj @@ -1,7 +1,8 @@ - Library + + true diff --git a/src/coreclr/tests/src/baseservices/typeequivalence/impl/TypeImpl.csproj b/src/coreclr/tests/src/baseservices/typeequivalence/impl/TypeImpl.csproj index 0654523590a820..4c64a59beda10e 100644 --- a/src/coreclr/tests/src/baseservices/typeequivalence/impl/TypeImpl.csproj +++ b/src/coreclr/tests/src/baseservices/typeequivalence/impl/TypeImpl.csproj @@ -1,7 +1,8 @@ - Library + + true diff --git a/src/coreclr/tests/src/baseservices/typeequivalence/simple/Simple.csproj b/src/coreclr/tests/src/baseservices/typeequivalence/simple/Simple.csproj index fcef3102f59492..e53815c61324c1 100644 --- a/src/coreclr/tests/src/baseservices/typeequivalence/simple/Simple.csproj +++ b/src/coreclr/tests/src/baseservices/typeequivalence/simple/Simple.csproj @@ -1,7 +1,8 @@ - Exe + + true