Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vector3GetHashCodeTest AV'ing on Windows release #20080

Closed
Tracked by #93172 ...
stephentoub opened this issue Feb 2, 2017 · 11 comments · Fixed by dotnet/corefx#16267
Closed
Tracked by #93172 ...

Vector3GetHashCodeTest AV'ing on Windows release #20080

stephentoub opened this issue Feb 2, 2017 · 11 comments · Fixed by dotnet/corefx#16267
Assignees
Labels
area-System.Numerics test-run-core Test failures in .NET Core test runs
Milestone

Comments

@stephentoub
Copy link
Member

With the latest CoreCLR update, this test is consistently AV'ing on Windows.

  Unhandled Exception: System.Reflection.TargetInvocationException: Exception has been thrown by the target of an invocation. ---> System.AccessViolationException: Attempted to read or write protected memory. This is often an indication that other memory is corrupt.
     at System.Numerics.Tests.Vector3Tests.Vector3GetHashCodeTest() in D:\j\workspace\windows_nt_re---37265eab\src\System.Numerics.Vectors\tests\Vector3Tests.cs:line 51

cc: @mellinoe, @CarolEidt

@stephentoub stephentoub self-assigned this Feb 2, 2017
@CarolEidt
Copy link
Contributor

@stephentoub - when I run the tests, this test doesn't seem to run. Has it been disabled? If so, how does one enable it to run the test?

@stephentoub
Copy link
Member Author

Has it been disabled? If so, how does one enable it to run the test?

Yes, I disabled it so that we could update CoreCLR. There's an [ActiveIssue] attribute on the test; just remove it, and it'll start running again.

@danmoseley
Copy link
Member

@CarolEidt did you have luck getting this to run?

@CarolEidt
Copy link
Contributor

@danmosemsft Yes,but I haven't got much farther than that.

@danmoseley
Copy link
Member

OK! let us know if you need anything on our side.

@CarolEidt
Copy link
Contributor

I was able to repro it and had a possible fix, but after merging with the latest coreclr, it seems to be failing before it hits the previously failing test. I'm continuing to work on it, but may have to pass it to someone else.

@danmoseley
Copy link
Member

danmoseley commented Feb 9, 2017

If it helps -- you can run tests just in one folder by going to the tests folder and doing msbuild /t:buildandtest or /t:test. You can also add [ActiveIssue(1)] on individual tests temporarily but obviously it's probably easier to just comment them out or remove them from the project.

@CarolEidt
Copy link
Contributor

I have a fix for this issue, and the other problem I was running into, which affects only Checked and Debug versions of the JIT.

@danmoseley
Copy link
Member

It's great the numeric tests catch these. Do you think https://github.com/dotnet/corefx/issues/15913 is related?

@danmoseley
Copy link
Member

dotnet/corefx#15913 can't be related since if I interpret the link in there corectly, it's failing on retail too.

@CarolEidt
Copy link
Contributor

@danmosemsft - I am fixing two issues with dotnet/coreclr#9496. The real issue behind this GetHashCode failure is an issue which causes an AV in retail, and an assert in Checked - though in Checked, if you ran the full set of tests, you would run into the other (Checked/Debug only) AV. So it's possible that dotnet/corefx#15913 is due to the same issue as this.

@msftgits msftgits transferred this issue from dotnet/corefx Jan 31, 2020
@msftgits msftgits added this to the 2.0.0 milestone Jan 31, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Numerics test-run-core Test failures in .NET Core test runs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants