Rename new Stream.Read/Write{Async} Span/Memory arguments to buffer

[stephentoub]

We'd previously decided to name these source/destination, but we also have an overriding principle that we should adhere to names used in existing overloads if possible, and we should only use source/destination to help in cases where we need to make the direction clear. Thus we should update the names in these new overloads before we ship them.

[JeremyKuhne]

@stephentoub Presumably we still want this for 2.1, right?

- public virtual ValueTask<int> ReadAsync(Memory<byte> destination, CancellationToken cancellationToken = default(CancellationToken))
- public virtual ValueTask WriteAsync(ReadOnlyMemory<byte> source, CancellationToken cancellationToken = default(CancellationToken))
+ public virtual ValueTask<int> ReadAsync(Memory<byte> buffer, CancellationToken cancellationToken = default(CancellationToken))
+ public virtual ValueTask WriteAsync(ReadOnlyMemory<byte> buffer, CancellationToken cancellationToken = default(CancellationToken))

@danmosemsft this is an easy one

[danmoseley]

Let's roll this in with any other consistentification we decide on tomorrow.

[JeremyKuhne]

Let's roll this in with any other consistentification we decide on tomorrow.

Confirmed that we want to match existing param names.

[ViktorHofer]

Jeremy have you already started with this? That should be quickly done. Should I help?

[Anipik]

@stephentoub is anything left here ? Coreclr and Corefx are merged. Corert doesnt have anything except the common folder

[stephentoub]

I still see some uses of source/destination after your changes:

  D:\repos\corefx\src\System.IO.Compression\src\System\IO\Compression\PositionPreservingWriteOnlyStreamWrapper.netcoreapp.cs(18):        public override ValueTask WriteAsync(ReadOnlyMemory<byte> source, CancellationToken cancellationToken = default(CancellationToken))
  D:\repos\corefx\src\System.IO.Compression.Brotli\src\System\IO\Compression\enc\BrotliStream.Compress.cs(66):        public override ValueTask WriteAsync(ReadOnlyMemory<byte> source, CancellationToken cancellationToken = default(CancellationToken))
  D:\repos\corefx\src\System.Net.Http\src\System\Net\Http\HttpContent.cs(734):            public override ValueTask WriteAsync(ReadOnlyMemory<byte> source, CancellationToken cancellationToken)
  D:\repos\corefx\src\System.Net.Http\src\System\Net\Http\HttpContent.cs(885):            public override ValueTask WriteAsync(ReadOnlyMemory<byte> source, CancellationToken cancellationToken = default)
  D:\repos\corefx\src\System.Net.Http\src\System\Net\Http\MultipartContent.cs(586):            public override ValueTask WriteAsync(ReadOnlyMemory<byte> source, CancellationToken cancellationToken = default) { throw new NotSupportedException(); }
  D:\repos\corefx\src\System.Net.Http\src\System\Net\Http\StreamContent.cs(170):            public override ValueTask WriteAsync(ReadOnlyMemory<byte> source, CancellationToken cancellationToken = default)
  D:\repos\corefx\src\System.Net.Http\src\System\Net\Http\SocketsHttpHandler\ChunkedEncodingWriteStream.cs(21):            public override ValueTask WriteAsync(ReadOnlyMemory<byte> source, CancellationToken ignored)
  D:\repos\corefx\src\System.Net.Http\src\System\Net\Http\SocketsHttpHandler\ContentLengthWriteStream.cs(19):            public override ValueTask WriteAsync(ReadOnlyMemory<byte> source, CancellationToken ignored) // token ignored as it comes from SendAsync

  D:\repos\corefx\src\System.IO.Compression.Brotli\src\System\IO\Compression\dec\BrotliStream.Decompress.cs(83):        public override ValueTask<int> ReadAsync(Memory<byte> destination, CancellationToken cancellationToken = default(CancellationToken))
  D:\repos\corefx\src\System.Net.Http\src\System\Net\Http\MultipartContent.cs(456):            public override ValueTask<int> ReadAsync(Memory<byte> destination, CancellationToken cancellationToken = default) =>
  D:\repos\corefx\src\System.Net.Http\src\System\Net\Http\CurlHandler\CurlHandler.CurlResponseMessage.cs(256):            public override ValueTask<int> ReadAsync(Memory<byte> destination, CancellationToken cancellationToken = default)

so it'd be good to clean those up, too.

If the only streams in corert are in shared, then there's nothing special to be done there.

Thanks.