Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add validation for DependencyModel and PlatformAbstractions nupkgs #2823

Closed
eerhardt opened this issue Jun 7, 2017 · 1 comment
Closed

Add validation for DependencyModel and PlatformAbstractions nupkgs #2823

eerhardt opened this issue Jun 7, 2017 · 1 comment
Labels
area-DependencyModel
Milestone
Future

Comments

@eerhardt
Copy link
Member

eerhardt commented Jun 7, 2017

We've regressed the DependencyModel's dependency on PlatformAbstractions twice in the past month. See:

dotnet/core-setup#2309
dotnet/core-setup#2646

We should add some validation to our build that ensures we don't break this again. I'm thinking a simple check that the dependency listed in DependencyModel is for the version of PlatformAbstractions that was produced.

/cc @Petermarcu @mikeharder
@msftgits msftgits transferred this issue from dotnet/core-setup Jan 30, 2020
@msftgits msftgits added this to the Future milestone Jan 30, 2020
@maryamariyan maryamariyan added the untriaged New issue has not been triaged by the area owner label Feb 23, 2020
@eerhardt
Copy link
Member Author

This is no longer necessary since DependencyModel no longer has a dependency on PlatformAbstractions. See dotnet/core-setup#5218.

@eerhardt eerhardt removed the untriaged New issue has not been triaged by the area owner label Feb 25, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-DependencyModel
Projects
None yet
Milestone
Future
Development

No branches or pull requests
3 participants
@maryamariyan @eerhardt @msftgits