Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix up System.Text.Encodings.Web test namespace to be consistent with other corefx projects #30509

Closed
ahsonkhan opened this issue Aug 6, 2019 · 3 comments
Closed

Fix up System.Text.Encodings.Web test namespace to be consistent with other corefx projects #30509

ahsonkhan opened this issue Aug 6, 2019 · 3 comments
Assignees
@igor-susic
Labels
area-System.Text.Encodings.Web good first issue Issue should be easy to implement, good for first-time contributors test-enhancement Improvements of test source code
Milestone
5.0.0

Comments

@ahsonkhan
Copy link
Contributor

See dotnet/corefx#39900 (comment)

Rename the namespace in the test project from Microsoft.Framework.WebEncoders to System.Text.Encodings.Web.Tests

https://github.com/dotnet/corefx/blob/c6f5ceedea28edf01ae7d3e13c02935669dad434/src/System.Text.Encodings.Web/tests/IHtmlEncoder.cs#L8

cc @GrabYourPitchforks
@igor-susic
Copy link
Contributor

@ahsonkhan This seems like a good start to get to know codebase a little and make the first contribution, if it is ok with you I would like to take this one.

@ahsonkhan
Copy link
Contributor Author

ahsonkhan commented Aug 8, 2019 •
edited
Loading

Awesome, go for it. I can't yet assign this to you, so I'll assign it to myself (as a placeholder).

@karelz, can we get @igor-susic added as a contributor?

@ahsonkhan ahsonkhan self-assigned this Aug 8, 2019
@igor-susic
Copy link
Contributor

@ahsonkhan No problem, I'm on it 👍

@karelz karelz assigned igor-susic and unassigned ahsonkhan Aug 9, 2019
@msftgits msftgits transferred this issue from dotnet/corefx Feb 1, 2020
@msftgits msftgits added this to the 5.0 milestone Feb 1, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@igor-susic igor-susic

Labels
area-System.Text.Encodings.Web good first issue Issue should be easy to implement, good for first-time contributors test-enhancement Improvements of test source code
Projects
None yet
Milestone
5.0.0
Development

No branches or pull requests
3 participants
@ahsonkhan @msftgits @igor-susic