Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AppContext switch test with RemoteExecutor failing in mono #32316

Closed
buyaa-n opened this issue Feb 14, 2020 · 4 comments
Closed

AppContext switch test with RemoteExecutor failing in mono #32316

buyaa-n opened this issue Feb 14, 2020 · 4 comments
Labels
area-System.Runtime runtime-mono specific to the Mono runtime test-bug Problem in test source code (most likely)
Milestone
5.0.0

Comments

@buyaa-n
Copy link
Contributor

buyaa-n commented Feb 14, 2020

AppContext switch test with RemoteExecutor failing on CI legs Linux-mono, Mac-mono.
More info: #32149 (comment)
Failure log:

Child exception:
  System.IO.InvalidDataException: A local file header is corrupt.
   at System.IO.Compression.ZipArchiveEntry.ThrowIfNotOpenable(Boolean needToUncompress, Boolean needToLoadIntoMemory) in /_/src/libraries/System.IO.Compression/src/System/IO/Compression/ZipArchiveEntry.cs:line 595
   at System.IO.Compression.ZipArchiveEntry.OpenInReadMode(Boolean checkOpenable) in /_/src/libraries/System.IO.Compression/src/System/IO/Compression/ZipArchiveEntry.cs:line 667
   at System.IO.Compression.ZipArchiveEntry.Open() in /_/src/libraries/System.IO.Compression/src/System/IO/Compression/ZipArchiveEntry.cs:line 294
   at System.IO.Compression.Tests.zip_InvalidParametersAndStrangeFiles.<>c.<ZipArchiveEntry_AppContext_Switch_SuppresHeaderValidation>b__6_0(String suppressString) in /_/src/libraries/System.IO.Compression/tests/ZipArchive/zip_InvalidParametersAndStrangeFiles.cs:line 151
   at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture) in /_/src/mono/netcore/System.Private.CoreLib/src/System/Reflection/RuntimeMethodInfo.cs:line 339

Child process:
  System.IO.Compression.Tests, Version=5.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51 System.IO.Compression.Tests.zip_InvalidParametersAndStrangeFiles+<>c Void <ZipArchiveEntry_AppContext_Switch_SuppresHeaderValidation>b__6_0(System.String)

Child arguments:
  True
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the untriaged New issue has not been triaged by the area owner label Feb 14, 2020
@marek-safar
Copy link
Contributor

/cc @CoffeeFlux

@ericstj
Copy link
Member

ericstj commented Feb 19, 2020

Could be related to when mono is running the static constructor which reads appcontext. Test isn't guaranteeing that the switch is set before running code which might touch that static constructor.

@joperezr joperezr added test-bug Problem in test source code (most likely) and removed untriaged New issue has not been triaged by the area owner labels Jul 7, 2020
@joperezr joperezr modified the milestones: Future, 5.0.0 Jul 7, 2020
@danmoseley
Copy link
Member

@buyaa-n -- I cannot find any test disabled for this issue, nor a test by this name, nor indeed any compression test disabled for Mono.

@buyaa-n
Copy link
Contributor Author

buyaa-n commented Aug 1, 2020

Yes, we are not using AppContext switch anymore and the test has removed,

@ghost ghost locked as resolved and limited conversation to collaborators Dec 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-System.Runtime runtime-mono specific to the Mono runtime test-bug Problem in test source code (most likely)
Projects
None yet
Milestone
5.0.0
Development

No branches or pull requests
6 participants
@marek-safar @danmoseley @ericstj @joperezr @Dotnet-GitSync-Bot @buyaa-n