Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Figure out the best flush threshold for serializer based on performance and real-world use cases #32356

Closed
ahsonkhan opened this issue Feb 15, 2020 · 1 comment · Fixed by #37170
Closed

Figure out the best flush threshold for serializer based on performance and real-world use cases #32356

ahsonkhan opened this issue Feb 15, 2020 · 1 comment · Fixed by #37170
Assignees
@steveharter
Labels
area-System.Text.Json tenet-performance Performance related issue
Milestone
5.0.0

Comments

@ahsonkhan
Copy link
Contributor

It's currently set to flush when the buffer is 90% full.

runtime/src/libraries/System.Text.Json/src/System/Text/Json/Serialization/JsonSerializer.Write.Stream.cs

Line 80 in d4b06b1

state.FlushThreshold = (int)(bufferWriter.Capacity * .9); //todo: determine best value here

cc @steveharter
@ahsonkhan ahsonkhan added this to the Future milestone Feb 15, 2020
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the untriaged New issue has not been triaged by the area owner label Feb 15, 2020
@ahsonkhan ahsonkhan added tenet-performance Performance related issue and removed untriaged New issue has not been triaged by the area owner labels Feb 15, 2020
@ahsonkhan ahsonkhan mentioned this issue Feb 15, 2020
Merged
@layomia layomia modified the milestones: Future, 5.0 Feb 21, 2020
@layomia
Copy link
Contributor

layomia commented Feb 21, 2020

Triage: change the comment to say if we have a lot of customers with large objects and we are flushing too often, make the buffer bigger; and close the issue.

@steveharter steveharter mentioned this issue May 29, 2020
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Dec 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@steveharter steveharter

Labels
area-System.Text.Json tenet-performance Performance related issue
Projects
None yet
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

Remove serializer todos and add comments steveharter/runtime
4 participants
@ahsonkhan @steveharter @layomia @Dotnet-GitSync-Bot