Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When initializing WriteStackFrame with re-entry during serialization, consider doing a type comparison #32358

Closed
ahsonkhan opened this issue Feb 15, 2020 · 0 comments · Fixed by #37170
Assignees
Milestone

Comments

@ahsonkhan
Copy link
Contributor

The intent of this TODO isn't super clear. @steveharter can you help fill in the details or what action is required?

public JsonConverter InitializeReEntry(Type type, JsonSerializerOptions options, string? propertyName = null)
{
JsonClassInfo newClassInfo = options.GetOrAddClass(type);
// todo: check if type==newtype and skip below?
// Set for exception handling calculation of JsonPath.
JsonPropertyNameAsString = propertyName;

cc @steveharter

@ahsonkhan ahsonkhan added this to the 5.0 milestone Feb 15, 2020
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the untriaged New issue has not been triaged by the area owner label Feb 15, 2020
@ahsonkhan ahsonkhan modified the milestones: 5.0, Future Feb 15, 2020
@ahsonkhan ahsonkhan removed the untriaged New issue has not been triaged by the area owner label Feb 15, 2020
@layomia layomia modified the milestones: Future, 5.0 Feb 21, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants