Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

COMPlus_EnableISA=0 variables no longer effect the IsSupported checks #34135

Closed
tannergooding opened this issue Mar 26, 2020 · 3 comments · Fixed by #34139
Closed

COMPlus_EnableISA=0 variables no longer effect the IsSupported checks #34135

tannergooding opened this issue Mar 26, 2020 · 3 comments · Fixed by #34139
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Milestone
5.0.0

Comments

@tannergooding
Copy link
Member

As per the title, the COMPlus_EnableISA=0 variables are no longer functioning. For example, setting COMPlus_EnableAVX=0 has no effect and Avx.IsSupported still returns true.

It does look to still impact parts of the system, such as the size of Vector<T>.
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the untriaged New issue has not been triaged by the area owner label Mar 26, 2020
@Dotnet-GitSync-Bot
Copy link
Collaborator

I couldn't figure out the best area label to add to this issue. Please help me learn by adding exactly one area label.

@tannergooding
Copy link
Member Author

CC. @CarolEidt, @echesakovMSFT, @davidwrighton

@tannergooding
Copy link
Member Author

https://github.com/dotnet/runtime/blob/master/src/coreclr/src/jit/compiler.cpp#L2354-L2355

    instructionSetFlags = EnsureInstructionSetFlagsAreValid(instructionSetFlags);
    opts.setSupportedISAs(jitFlags.GetInstructionSetFlags());

Is the second line supposed to be opts.setSupportedISAs(instructionSetFlags);?

@tannergooding tannergooding mentioned this issue Mar 26, 2020
Closed
@BruceForstall BruceForstall added this to the 5.0 milestone Mar 26, 2020
@BruceForstall BruceForstall added area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI and removed untriaged New issue has not been triaged by the area owner labels Mar 26, 2020
@tannergooding tannergooding mentioned this issue Mar 26, 2020
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Dec 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

Fixing opts.setSupportedISAs to use the computed instructionSetFlags value tannergooding/runtime
3 participants
@tannergooding @BruceForstall @Dotnet-GitSync-Bot