Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CreatePropertyInfoForClassInfo run twice? #34453

Closed
NinoFloris opened this issue Apr 2, 2020 · 1 comment · Fixed by #34675
Closed

CreatePropertyInfoForClassInfo run twice? #34453

NinoFloris opened this issue Apr 2, 2020 · 1 comment · Fixed by #34675
Assignees
@layomia
Labels
area-System.Text.Json
Milestone
5.0.0

Comments

@NinoFloris
Copy link
Contributor

CreatePropertyInfoForClassInfo run twice?

See 90 and 97, arguments are equivalent:

runtime/src/libraries/System.Text.Json/src/System/Text/Json/Serialization/JsonClassInfo.cs

Lines 90 to 97 in 4a80495

PropertyInfoForClassInfo = CreatePropertyInfoForClassInfo(Type, runtimeType, converter, Options);
switch (ClassType)
{
case ClassType.Object:
{
// Create the policy property.
PropertyInfoForClassInfo = CreatePropertyInfoForClassInfo(type, runtimeType, converter!, options);

@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the untriaged New issue has not been triaged by the area owner label Apr 2, 2020
@Dotnet-GitSync-Bot
Copy link
Collaborator

I couldn't figure out the best area label to add to this issue. Please help me learn by adding exactly one area label.

@layomia layomia self-assigned this Apr 2, 2020
@layomia layomia removed the untriaged New issue has not been triaged by the area owner label Apr 2, 2020
@layomia layomia added this to the 5.0 milestone Apr 2, 2020
@layomia layomia mentioned this issue Apr 8, 2020
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Dec 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@layomia layomia

Labels
area-System.Text.Json
Projects
None yet
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

Add JsonIncludeAttribute & support for non-public accessors layomia/dotnet_runtime
4 participants
@NinoFloris @jeffschwMSFT @layomia @Dotnet-GitSync-Bot