-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WebAssembly should support handling runtimeconfig.json #38433
Comments
Could you clarify why? We'd need to copy the files to the temp file system and add all the baggage for handling the json logic which is not necessary for self-contained setup. I think a better approach is to add the configProperties section which is probably the only relevant part for self-contained configs to csproj PropertyGroup and handle it during build. |
Yeah I was imprecise when creating the title, I don't think we need to necessarily read the file as part of the WASM process but we need to handle it somehow rather than just ignoring it. |
Do you mean - read the |
We should just leverage the runtimeConfig.json task we have for mobile AOT for WASM AOT |
Yea, this is exactly what the runtimeConfig.json task is meant to do. The WasmApp target needs to be updated to use it, and then driver.c needs to be updated to call the runtime API that consumes the binary blob of the parsed json file. |
Is this going to be completed for .NET 6? Using AppContext switches is becoming more and more important in order to support feature switches. For example, the plan in #55102 is relying on the fact that an AppContext switch will be set in applications that will be trimmed during |
Yes, a PR should be up soon |
See #37535 (comment)
The text was updated successfully, but these errors were encountered: