Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warnings for coreclr_static during build #38773

Closed
AaronRobinsonMSFT opened this issue Jul 3, 2020 · 7 comments
Closed

Warnings for coreclr_static during build #38773

AaronRobinsonMSFT opened this issue Jul 3, 2020 · 7 comments
Assignees
@VSadov
Labels
area-Infrastructure-coreclr runtime-coreclr specific to the CoreCLR runtime
Milestone
6.0.0

Comments

@AaronRobinsonMSFT
Copy link
Member

AaronRobinsonMSFT commented Jul 3, 2020 •
edited
Loading

The following warnings are triggered when building on Windows_NT.x86.Debug.

  gcdecode.obj : warning LNK4006: "struct InfoHdrSmall const * const infoHdrShortcut" (?infoHdrShortcut@@3QBUInfoHdrSmall@@B) already defined in gcdecode.obj; second definition ignored [D:\runtime\artifacts\obj\coreclr\Windows_NT.x86.Debug\src\dlls\mscoree\coreclr\coreclr_static.vcxproj]
  gcdecode.obj : warning LNK4006: "unsigned int const * const callPatternTable" (?callPatternTable@@3QBIB) already defined in gcdecode.obj; second definition ignored [D:\runtime\artifacts\obj\coreclr\Windows_NT.x86.Debug\src\dlls\mscoree\coreclr\coreclr_static.vcxproj]
    hostallocator.cpp
  gcdecode.obj : warning LNK4006: "unsigned int const * const callCommonDelta" (?callCommonDelta@@3QBIB) already defined in gcdecode.obj; second definition ignored [D:\runtime\artifacts\obj\coreclr\Windows_NT.x86.Debug\src\dlls\mscoree\coreclr\coreclr_static.vcxproj]
  gcdecode.obj : warning LNK4006: "public: bool __thiscall InfoHdrSmall::isHeaderMatch(struct InfoHdr const &)const " (?isHeaderMatch@InfoHdrSmall@@QBE_NABUInfoHdr@@@Z) already defined in gcdecode.obj; second definition ignored [D:\runtime\artifacts\obj\coreclr\Windows_NT.x86.Debug\src\dlls\mscoree\coreclr\coreclr_static.vcxproj]
  gcdecode.obj : warning LNK4006: "unsigned char const * __fastcall decodeHeader(unsigned char const *,unsigned int,struct InfoHdr *)" (?decodeHeader@@YIPBEPBEIPAUInfoHdr@@@Z) already defined in gcdecode.obj; second definition ignored [D:\runtime\artifacts\obj\coreclr\Windows_NT.x86.Debug\src\dlls\mscoree\coreclr\coreclr_static.vcxproj]
  gcdecode.obj : warning LNK4006: "unsigned int __fastcall decodeUnsigned(unsigned char const *,unsigned int *)" (?decodeUnsigned@@YIIPBEPAI@Z) already defined in gcdecode.obj; second definition ignored [D:\runtime\artifacts\obj\coreclr\Windows_NT.x86.Debug\src\dlls\mscoree\coreclr\coreclr_static.vcxproj]
  gcdecode.obj : warning LNK4006: "unsigned int __fastcall decodeUDelta(unsigned char const *,unsigned int *,unsigned int)" (?decodeUDelta@@YIIPBEPAII@Z) already defined in gcdecode.obj; second definition ignored [D:\runtime\artifacts\obj\coreclr\Windows_NT.x86.Debug\src\dlls\mscoree\coreclr\coreclr_static.vcxproj]
  gcdecode.obj : warning LNK4006: "unsigned int __fastcall decodeSigned(unsigned char const *,int *)" (?decodeSigned@@YIIPBEPAH@Z) already defined in gcdecode.obj; second definition ignored [D:\runtime\artifacts\obj\coreclr\Windows_NT.x86.Debug\src\dlls\mscoree\coreclr\coreclr_static.vcxproj]
  gcdecode.obj : warning LNK4006: "void __fastcall decodeCallPattern(int,unsigned int *,unsigned int *,unsigned int *,unsigned int *)" (?decodeCallPattern@@YIXHPAI000@Z) already defined in gcdecode.obj; second definition ignored [D:\runtime\artifacts\obj\coreclr\Windows_NT.x86.Debug\src\dlls\mscoree\coreclr\coreclr_static.vcxproj]

/cc @VSadov
@AaronRobinsonMSFT AaronRobinsonMSFT added the runtime-coreclr specific to the CoreCLR runtime label Jul 3, 2020
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added area-Infrastructure-coreclr untriaged New issue has not been triaged by the area owner labels Jul 3, 2020
@jashook jashook added area-Infrastructure-coreclr and removed area-Infrastructure-coreclr untriaged New issue has not been triaged by the area owner labels Jul 13, 2020
@jashook jashook added this to the Future milestone Jul 13, 2020
@BruceForstall
Copy link
Member

I also see this in other x86 builds, e.g., Windows_NT.x86.Release:

    48>gcdecode.obj : warning LNK4006: "struct InfoHdrSmall const * const infoHdrShortcut" (?infoHdrShortcut@@3QBUInfoHdrSmall@@B) already defined in gcdecode.obj; second definition ignored [C:\gh\runtime3\artifacts\obj\coreclr\Windows_NT.x86.Release\src\dlls\mscoree\coreclr\coreclr_static.vcxproj]
    48>gcdecode.obj : warning LNK4006: "unsigned int const * const callPatternTable" (?callPatternTable@@3QBIB) already defined in gcdecode.obj; second definition ignored [C:\gh\runtime3\artifacts\obj\coreclr\Windows_NT.x86.Release\src\dlls\mscoree\coreclr\coreclr_static.vcxproj]
    48>gcdecode.obj : warning LNK4006: "unsigned int const * const callCommonDelta" (?callCommonDelta@@3QBIB) already defined in gcdecode.obj; second definition ignored [C:\gh\runtime3\artifacts\obj\coreclr\Windows_NT.x86.Release\src\dlls\mscoree\coreclr\coreclr_static.vcxproj]
    48>gcdecode.obj : warning LNK4006: "public: bool __thiscall InfoHdrSmall::isHeaderMatch(struct InfoHdr const &)const " (?isHeaderMatch@InfoHdrSmall@@QBE_NABUInfoHdr@@@Z) already defined in gcdecode.obj; second definition ignored [C:\gh\runtime3\artifacts\obj\coreclr\Windows_NT.x86.Release\src\dlls\mscoree\coreclr\coreclr_static.vcxproj]
    48>gcdecode.obj : warning LNK4006: "void __fastcall decodeCallPattern(int,unsigned int *,unsigned int *,unsigned int *,unsigned int *)" (?decodeCallPattern@@YIXHPAI000@Z) already defined in gcdecode.obj; second definition ignored [C:\gh\runtime3\artifacts\obj\coreclr\Windows_NT.x86.Release\src\dlls\mscoree\coreclr\coreclr_static.vcxproj]
    48>gcdecode.obj : warning LNK4006: "unsigned char const * __fastcall decodeHeader(unsigned char const *,unsigned int,struct InfoHdr *)" (?decodeHeader@@YIPBEPBEIPAUInfoHdr@@@Z) already defined in gcdecode.obj; second definition ignored [C:\gh\runtime3\artifacts\obj\coreclr\Windows_NT.x86.Release\src\dlls\mscoree\coreclr\coreclr_static.vcxproj]
    48>gcdecode.obj : warning LNK4006: "unsigned int __fastcall decodeSigned(unsigned char const *,int *)" (?decodeSigned@@YIIPBEPAH@Z) already defined in gcdecode.obj; second definition ignored [C:\gh\runtime3\artifacts\obj\coreclr\Windows_NT.x86.Release\src\dlls\mscoree\coreclr\coreclr_static.vcxproj]
    48>gcdecode.obj : warning LNK4006: "unsigned int __fastcall decodeUDelta(unsigned char const *,unsigned int *,unsigned int)" (?decodeUDelta@@YIIPBEPAII@Z) already defined in gcdecode.obj; second definition ignored [C:\gh\runtime3\artifacts\obj\coreclr\Windows_NT.x86.Release\src\dlls\mscoree\coreclr\coreclr_static.vcxproj]
    48>gcdecode.obj : warning LNK4006: "unsigned int __fastcall decodeUnsigned(unsigned char const *,unsigned int *)" (?decodeUnsigned@@YIIPBEPAI@Z) already defined in gcdecode.obj; second definition ignored [C:\gh\runtime3\artifacts\obj\coreclr\Windows_NT.x86.Release\src\dlls\mscoree\coreclr\coreclr_static.vcxproj]

@BruceForstall BruceForstall modified the milestones: Future, 6.0.0 Oct 29, 2020
@VSadov
Copy link
Member

VSadov commented Oct 29, 2020

That could be from static-linking change. Perhaps not from the change itself, but something in the change could cause linker to warn on something that was there.

I will take a look.

@VSadov VSadov self-assigned this Oct 29, 2020
@VSadov
Copy link
Member

VSadov commented Oct 29, 2020

Oh, I see this is from Jul 3. Is it even still an issue?

Anyways, worth checking this out.

@BruceForstall
Copy link
Member

@VSadov Yes, this is still an issue; I repro'ed it today.

@sandreenko
Copy link
Contributor

The issue still exists.

@elinor-fung
Copy link
Member

@VSadov - I think you fixed this with #48254?

@VSadov
Copy link
Member

VSadov commented Mar 12, 2021

Yes, the warnings actually became errors when singlefile started building in the same build graph as clr, so I fixed the duplication.
Just forgot about this bug. I will close it. It is fixed.
Thanks, for reminding!!

@VSadov VSadov closed this as completed Mar 12, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Apr 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@VSadov VSadov

Labels
area-Infrastructure-coreclr runtime-coreclr specific to the CoreCLR runtime
Projects
None yet
Milestone
6.0.0
Development

No branches or pull requests
7 participants
@jashook @VSadov @BruceForstall @sandreenko @AaronRobinsonMSFT @Dotnet-GitSync-Bot @elinor-fung