Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IncludeAllContentForSelfExtract only extracts native assemblies, when it should extract everything #42352

Closed
agocke opened this issue Sep 16, 2020 · 3 comments · Fixed by #42435
Closed

IncludeAllContentForSelfExtract only extracts native assemblies, when it should extract everything #42352

agocke opened this issue Sep 16, 2020 · 3 comments · Fixed by #42435
Assignees
@mateoatr
Labels
area-Single-File blocking-release
Milestone
5.0.0

Comments

@agocke
Copy link
Member

agocke commented Sep 16, 2020

dotnet publish -r win-x64 -p:PublishSingleFile=true -p:IncludeAllContentForSelfExtract shouldn't be loading managed assemblies from the bundle, but it seems it still is.
@Dotnet-GitSync-Bot
Copy link
Collaborator

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the untriaged New issue has not been triaged by the area owner label Sep 16, 2020
@ghost
Copy link

ghost commented Sep 16, 2020

Tagging subscribers to this area: @agocke
See info in area-owners.md if you want to be subscribed.

@agocke agocke added this to the 5.0.0 milestone Sep 16, 2020
@agocke agocke removed the untriaged New issue has not been triaged by the area owner label Sep 16, 2020
@agocke
Copy link
Member Author

agocke commented Sep 16, 2020

@mateoatr Could you take a look at this?

@agocke agocke mentioned this issue Sep 16, 2020
Closed
@mateoatr mateoatr mentioned this issue Sep 18, 2020
Merged
This was referenced Sep 28, 2020
Closed
Closed
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Dec 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mateoatr mateoatr

Labels
area-Single-File blocking-release
Projects
None yet
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

Extract bundled files when IncludeAllContentForSelfExtract is set mateoatr/runtime
3 participants
@agocke @mateoatr @Dotnet-GitSync-Bot