Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ninja build on Windows generates obj files into a wrong directory subtree #45955

Closed
janvorli opened this issue Dec 11, 2020 · 4 comments · Fixed by #49715
Closed

Ninja build on Windows generates obj files into a wrong directory subtree #45955

janvorli opened this issue Dec 11, 2020 · 4 comments · Fixed by #49715
Assignees
@jkoritzinsky
Labels
area-Infrastructure
Milestone
6.0.0

Comments

@janvorli
Copy link
Member

I have found that on Windows build with ninja generates obj files into artifacts\nmakeobj\windows.x64.Debug instead of artifacts\obj\coreclr\windows.x64.Checked\src. I think that should be changed to match the unix / non-ninja folder structure.
@janvorli janvorli added this to the 6.0.0 milestone Dec 11, 2020
@ghost
Copy link

ghost commented Dec 11, 2020

Tagging subscribers to this area: @ViktorHofer
See info in area-owners.md if you want to be subscribed.

Issue Details

I have found that on Windows build with ninja generates obj files into artifacts\nmakeobj\windows.x64.Debug instead of artifacts\obj\coreclr\windows.x64.Checked\src. I think that should be changed to match the unix / non-ninja folder structure.

Author: janvorli
Assignees: -
Labels:

area-Infrastructure
Milestone: 6.0.0

@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the untriaged New issue has not been triaged by the area owner label Dec 11, 2020
@janvorli
Copy link
Member Author

cc: @jkoritzinsky

@ViktorHofer
Copy link
Member

@jkoritzinsky can you please take a look at this one?

@ViktorHofer ViktorHofer removed the untriaged New issue has not been triaged by the area owner label Feb 23, 2021
@jkoritzinsky
Copy link
Member

I'll take a look when I have some free cycles.

@jkoritzinsky jkoritzinsky self-assigned this Feb 23, 2021
@jkoritzinsky jkoritzinsky mentioned this issue Mar 16, 2021
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Mar 16, 2021
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Apr 5, 2021
@ghost ghost locked as resolved and limited conversation to collaborators May 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jkoritzinsky jkoritzinsky

Labels
area-Infrastructure
Projects
None yet
Milestone
6.0.0
Development

Successfully merging a pull request may close this issue.

Make Ninja the default CMake generator on Windows for the repo jkoritzinsky/runtime
4 participants
@jkoritzinsky @ViktorHofer @janvorli @Dotnet-GitSync-Bot