Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mono] MSBuild Task housekeeping #53873

Closed
2 of 3 tasks
steveisok opened this issue Jun 8, 2021 · 4 comments
Closed
2 of 3 tasks

[Mono] MSBuild Task housekeeping #53873

steveisok opened this issue Jun 8, 2021 · 4 comments
Assignees
Milestone

Comments

@steveisok
Copy link
Member

steveisok commented Jun 8, 2021

As discovered in #53827, we are hardcoding paths to net6.0 and net472 for MSBuild tasks that are configured to multi-target. We should instead create a template props file and generate with the tool version we have configured in runtime.

Also, while we are at it, we should create a property similar to NetCoreAppToolCurrent and use it within our tasks. NetCoreAppToolCurrent will likely bump more aggressively between new sdks and we won't really need to.

So, the issue boils down to:

  • Create a property similar to NetCoreAppToolCurrent called NetCoreAppMSBuildTasksCurrent and update the tasks in src/tasks to use it.
  • Create a template Sdk.props file for Microsoft.NET.Runtime.RuntimeConfigParser.Task and Microsoft.NET.Runtime.MonoAOTCompiler.Task
  • Create a template Sdk.targets file for Microsoft.NET.Runtime.WebAssembly.Sdk
@steveisok steveisok added this to the 6.0.0 milestone Jun 8, 2021
@ghost
Copy link

ghost commented Jun 8, 2021

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

As discovered in #53827, we are hardcoding paths to net6.0 and net472 for MSBuild tasks that are configured to multi-target. We should instead create a template props file and generate with the tool version we have configured in runtime.

Also, while we are at it, we should create a property similar to NetCoreAppToolCurrent and use it within our tasks. NetCoreAppToolCurrent will likely bump more aggressively between new sdks and we won't really need to.

So, the issue boils down to:

  • Create a property similar to NetCoreAppToolCurrent called NetCoreAppMSBuildTasksCurrent and update the tasks in src/tasks to use it.
  • Create a template Sdk.props file for Microsoft.NET.Runtime.RuntimeConfigParser.Task and Microsoft.NET.Runtime.MonoAOTCompiler.Task
  • Create a template Sdk.targets file for Microsoft.NET.Runtime.WebAssembly.Sdk
Author: steveisok
Assignees: -
Labels:

area-Infrastructure-mono

Milestone: 6.0.0

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Jun 8, 2021
@steveisok
Copy link
Member Author

/cc @lewing @akoeplinger @radical

@radical
Copy link
Member

radical commented Jun 8, 2021

Create a property similar to NetCoreAppToolCurrent called NetCoreAppMSBuildTasksCurrent and update the tasks in src/tasks to use it.

NetCoreAppMSBuildTasksCurrent - this one would for the .net framework, right? Why *Current then? Naming can be discussed on the PR too.

@steveisok
Copy link
Member Author

@radical Naming is always up for discussion - especially when I name things ;-)

@akoeplinger akoeplinger removed the untriaged New issue has not been triaged by the area owner label Jun 17, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Aug 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants