dotnet --info reports duplicates of paths

[ericstj]

Description

Run dotnet --info

Expect: one instance of each path
Actual: duplicate paths for every entry

.NET SDKs installed:
  6.0.100-rc.2.21478.25 [C:\Program Files\dotnet\sdk]
  6.0.100-rc.2.21478.25 [C:\Program Files\dotnet\sdk]

.NET runtimes installed:
  Microsoft.AspNetCore.App 6.0.0-rc.2.21475.12 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.AspNetCore.App 6.0.0-rc.2.21475.12 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.NETCore.App 6.0.0-rc.2.21474.18 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 6.0.0-rc.2.21474.18 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.WindowsDesktop.App 6.0.0-rc.2.21475.3 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
  Microsoft.WindowsDesktop.App 6.0.0-rc.2.21475.3 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]

Configuration

• Which version of .NET is the code running on? 6.0 RC2
• What OS and version, and what distro if applicable? Windows
• What is the architecture (x64, x86, ARM, ARM64)? All
• Do you know whether it is specific to that configuration? Yes, specific to Windows, not specific to architecture

Regression?

Yes, previous RC1.

This is caused by this: dotnet/installer#11843
Previously the bundle would set these properties without trailing slash: https://github.com/dotnet/installer/pull/11843/files#diff-42255eeced0cb7937c40024646092ce85055a361283ed45dec27adbab7996905L124
It was hardcoding the values here, which we had to remove because it couldn't get it right, nor could we calculate it.

This might be different in GA, since we changed how those keys are written again with a7e9f9f

Need to test GA to see if we should try to change this in the installer or deal with it in the host.

[dotnet-issue-labeler]

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

[ericstj]

The same repros in GA. Looks like MSI appends a trailing slash to all directory properties and I don't see a good way to trim it, short of a custom action.

One possible fix is to normalize these paths by stripping the slash. Looks like that is already done for the dotnet_dir seems reasonable to apply that same normalization to the global_dirs

runtime/src/native/corehost/hostmisc/utils.cpp

Lines 294 to 313 in db1b302

	if (!dotnet_dir.empty())
	{
	// own_dir contains DIR_SEPARATOR appended that we need to remove.
	dotnet_dir_temp = dotnet_dir;
	remove_trailing_dir_seperator(&dotnet_dir_temp);
	locations->push_back(dotnet_dir_temp);
	}
	std::vector<pal::string_t> global_dirs;
	if (multilevel_lookup && pal::get_global_dotnet_dirs(&global_dirs))
	{
	for (pal::string_t dir : global_dirs)
	{
	// avoid duplicate paths
	if (!pal::are_paths_equal_with_normalized_casing(dir, dotnet_dir_temp))
	{
	locations->push_back(dir);
	}
	}

[ghost]

Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Description

Run dotnet --info

Expect: one instance of each path
Actual: duplicate paths for every entry

.NET SDKs installed:
  6.0.100-rc.2.21478.25 [C:\Program Files\dotnet\sdk]
  6.0.100-rc.2.21478.25 [C:\Program Files\dotnet\sdk]

.NET runtimes installed:
  Microsoft.AspNetCore.App 6.0.0-rc.2.21475.12 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.AspNetCore.App 6.0.0-rc.2.21475.12 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.NETCore.App 6.0.0-rc.2.21474.18 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 6.0.0-rc.2.21474.18 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.WindowsDesktop.App 6.0.0-rc.2.21475.3 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
  Microsoft.WindowsDesktop.App 6.0.0-rc.2.21475.3 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]

Configuration

• Which version of .NET is the code running on? 6.0 RC2
• What OS and version, and what distro if applicable? Windows
• What is the architecture (x64, x86, ARM, ARM64)? All
• Do you know whether it is specific to that configuration? Yes, specific to Windows, not specific to architecture

Regression?

Yes, previous RC1.

This is caused by this: dotnet/installer#11843
Previously the bundle would set these properties without trailing slash: https://github.com/dotnet/installer/pull/11843/files#diff-42255eeced0cb7937c40024646092ce85055a361283ed45dec27adbab7996905L124
It was hardcoding the values here, which we had to remove because it couldn't get it right, nor could we calculate it.

This might be different in GA, since we changed how those keys are written again with a7e9f9f

Need to test GA to see if we should try to change this in the installer or deal with it in the host.

Author:	ericstj
Assignees:	-
Labels:	area-Host, untriaged
Milestone:	-

[ericstj]

This is going to be a rather visible bug on Windows. Everyone will hit it (not just ARM64). I recommend we take it for for 6.0. The fix should be very low risk.

[agocke]

@mateoatr Could you take a look?

[vdanche]

Issue still repro on 17.0 preview 6(release channel) or 17.1 preview 1 + RTM SDK

[agocke]

The fix for this looks low, but not zero risk: https://github.com/dotnet/runtime/pull/59890/files

Unfortunately, the window for runtime changes is basically closed (and has been for a bit). I think we take this for servicing or not at all.

[ericstj]

Reopening for 6.0 consideration.

[pedoc]

Reopening for 6.0 consideration.

7.0.100-alpha.1.21518.14 The problem still exists

[vitek-karas]

The change probably didn't make it into dotnet/installer - the SDK -> installer integration has been stuck for a few days: dotnet/installer#12361

[ericstj]

Note that the fix for this was approved for both 3.1 and 5.0, however it was after the builds for the November release were complete.

#60496
dotnet/core-setup#9186