Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn on analyzer crashes in runtime repo #78412

Closed
marek-safar opened this issue Nov 15, 2022 · 7 comments · Fixed by #90358
Closed

Warn on analyzer crashes in runtime repo #78412

marek-safar opened this issue Nov 15, 2022 · 7 comments · Fixed by #90358
Assignees
Milestone

Comments

@marek-safar
Copy link
Contributor

Trimming analyzers are complex and we don't have comprehensive code coverage for them right now. We should enable them for whole runtime repo to catch problems like dotnet/linker#3046 earlier.

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@ghost ghost added the untriaged New issue has not been triaged by the area owner label Nov 15, 2022
@ghost
Copy link

ghost commented Nov 15, 2022

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

Trimming analyzers are complex and we don't have comprehensive code coverage for them right now. We should enable them for whole runtime repo to catch problems like dotnet/linker#3046 earlier.

Author: marek-safar
Assignees: -
Labels:

area-Infrastructure-libraries, untriaged

Milestone: -

@vitek-karas
Copy link
Member

@tlakollo @sbomer - I think they're enabled - at least looking at binlog locally they're in the list of analyzers and they're enabled. I didn't try to break it to get it to warn, but I know this worked last time I played with trimming annotations in the runtime repo.
That said - the above issue is from runtime repo - so I guess I don't know.

@sbomer
Copy link
Member

sbomer commented Nov 15, 2022

Yes, they're enabled on dotnet/runtime but crashes usually aren't usually surfaced because they turn into AD0001 warnings which runtime hides. See dotnet/linker#2847 (comment).

@sbomer sbomer changed the title Enable trimming analyzers on runtime repo Warn on analyzer crashes in runtime repo Nov 15, 2022
@marek-safar marek-safar added this to the 8.0.0 milestone Nov 16, 2022
@marek-safar marek-safar removed the untriaged New issue has not been triaged by the area owner label Nov 16, 2022
@ViktorHofer
Copy link
Member

Moving to meta as there is no infrastructure work needed.

@ghost
Copy link

ghost commented Nov 25, 2022

Tagging subscribers to this area: @dotnet/area-meta
See info in area-owners.md if you want to be subscribed.

Issue Details

Trimming analyzers are complex and we don't have comprehensive code coverage for them right now. We should enable them for whole runtime repo to catch problems like dotnet/linker#3046 earlier.

Author: marek-safar
Assignees: -
Labels:

area-Meta

Milestone: 8.0.0

@ericstj
Copy link
Member

ericstj commented Aug 10, 2023

Remaining work here is to turn on AD0001 as a warning and see if we are clean. IMO this is OK to do - if it becomes a problem we NoWarn it in the faulting project and file an issue.

@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Aug 11, 2023
@ericstj ericstj self-assigned this Aug 11, 2023
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Aug 11, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Sep 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants