-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warn on analyzer crashes in runtime repo #78412
Comments
I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label. |
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries Issue DetailsTrimming analyzers are complex and we don't have comprehensive code coverage for them right now. We should enable them for whole runtime repo to catch problems like dotnet/linker#3046 earlier.
|
@tlakollo @sbomer - I think they're enabled - at least looking at binlog locally they're in the list of analyzers and they're enabled. I didn't try to break it to get it to warn, but I know this worked last time I played with trimming annotations in the runtime repo. |
Yes, they're enabled on dotnet/runtime but crashes usually aren't usually surfaced because they turn into |
Moving to meta as there is no infrastructure work needed. |
Tagging subscribers to this area: @dotnet/area-meta Issue DetailsTrimming analyzers are complex and we don't have comprehensive code coverage for them right now. We should enable them for whole runtime repo to catch problems like dotnet/linker#3046 earlier.
|
Remaining work here is to turn on AD0001 as a warning and see if we are clean. IMO this is OK to do - if it becomes a problem we |
Trimming analyzers are complex and we don't have comprehensive code coverage for them right now. We should enable them for whole runtime repo to catch problems like dotnet/linker#3046 earlier.
The text was updated successfully, but these errors were encountered: