[NativeAOT] Assertion failed 'node->IsUnusedValue() && "found an unmarked unused value"' - when compiling System.Net.Sockets.Tests #84112

VSadov · 2023-03-30T03:13:08Z

    // At this point the unusedDefs map should contain only unused values.
    if (checkUnusedValues)
    {
        for (auto kvp : unusedDefs)
        {
            GenTree* node = kvp.Key();
            assert(node->IsUnusedValue() && "found an unmarked unused value");      <==== here
            assert(!node->isContained() && "a contained node should have a user");
        }
    }

 	KernelBase.dll!wil::details::DebugBreak(void)	Unknown
>	clrjit_win_x64_x64.dll!assertAbort(const char * why, const char * file, unsigned int line) Line 304	C++
 	clrjit_win_x64_x64.dll!LIR::Range::CheckLIR(Compiler * compiler, bool checkUnusedValues) Line 1692	C++
 	[Inline Frame] clrjit_win_x64_x64.dll!Lowering::CheckBlock(Compiler * compiler, BasicBlock *) Line 7351	C++
 	[Inline Frame] clrjit_win_x64_x64.dll!Lowering::LowerBlock(BasicBlock *) Line 7382	C++
 	clrjit_win_x64_x64.dll!Lowering::DoPhase() Line 7151	C++
 	clrjit_win_x64_x64.dll!Phase::Run() Line 62	C++
 	clrjit_win_x64_x64.dll!Compiler::compCompile(void * * methodCodePtr, unsigned int * methodCodeSize, JitFlags * compileFlags) Line 5088	C++
 	clrjit_win_x64_x64.dll!Compiler::compCompileHelper(CORINFO_MODULE_STRUCT_ * classPtr, ICorJitInfo * compHnd, CORINFO_METHOD_INFO * methodInfo, void * * methodCodePtr, unsigned int * methodCodeSize, JitFlags * compileFlags) Line 7025	C++
 	[Inline Frame] clrjit_win_x64_x64.dll!Compiler::compCompile::__l164::__Body::Run(Compiler::compCompile::__l2::__JITParam *) Line 6181	C++
 	clrjit_win_x64_x64.dll!Compiler::compCompile(CORINFO_MODULE_STRUCT_ * classPtr, void * * methodCodePtr, unsigned int * methodCodeSize, JitFlags * compileFlags) Line 6185	C++
 	[Inline Frame] clrjit_win_x64_x64.dll!jitNativeCode::__l8::__Body::Run::__l6::__Body::Run(jitNativeCode::__l8::__Body::Run::__l5::__JITParam *) Line 7668	C++
 	clrjit_win_x64_x64.dll!`jitNativeCode'::`8'::__Body::Run(jitNativeCode::__l2::__JITParam * __JITpParam) Line 7671	C++
 	clrjit_win_x64_x64.dll!jitNativeCode(CORINFO_METHOD_STRUCT_ * methodHnd, CORINFO_MODULE_STRUCT_ * classPtr, ICorJitInfo * compHnd, CORINFO_METHOD_INFO * methodInfo, void * * methodCodePtr, unsigned int * methodCodeSize, JitFlags * compileFlags, void * inlineInfoPtr) Line 7695	C++
 	clrjit_win_x64_x64.dll!CILJit::compileMethod(ICorJitInfo * compHnd, CORINFO_METHOD_INFO * methodInfo, unsigned int flags, unsigned char * * entryAddress, unsigned int * nativeSizeOfCode) Line 272	C++
 	jitinterface_x64.dll!JitCompileMethod(CorInfoExceptionClass * * ppException, ICorJitCompiler * pJit, void * thisHandle, void * * callbacks, CORINFO_METHOD_INFO * methodInfo, unsigned int flags, unsigned char * * entryAddress, unsigned int * nativeSizeOfCode) Line 34	C++
 	ilc.exe!ILCompiler_RyuJit_Internal_JitInterface_CorInfoImpl__JitCompileMethod�()	Unknown
 	ilc.exe!ILCompiler_RyuJit_Internal_JitInterface_CorInfoImpl__CompileMethodInternal() Line 358	Unknown
 	ilc.exe!ILCompiler_RyuJit_Internal_JitInterface_CorInfoImpl__CompileMethod() Line 62	Unknown
 	ilc.exe!ILCompiler_RyuJit_ILCompiler_RyuJitCompilation__CompileSingleMethod_0() Line 190	Unknown
 	ilc.exe!System_Threading_Tasks_Parallel_System_Threading_Tasks_Parallel___c__DisplayClass19_0_1<System___Canon>___ForWorker_b__1() Line 1060	Unknown
 	ilc.exe!System_Threading_Tasks_Parallel_System_Threading_Tasks_TaskReplicator_Replica__Execute() Line 79	Unknown
 	ilc.exe!S_P_CoreLib_System_Threading_ExecutionContext__RunFromThreadPoolDispatchLoop() Line 268	Unknown
 	ilc.exe!S_P_CoreLib_System_Threading_Tasks_Task__ExecuteWithThreadLocal() Line 2353	Unknown
 	ilc.exe!S_P_CoreLib_System_Threading_ThreadPoolWorkQueue__Dispatch() Line 919	Unknown
 	ilc.exe!S_P_CoreLib_System_Threading_ThreadPool__DispatchCallback() Line 376	Unknown

The text was updated successfully, but these errors were encountered:

ghost · 2023-03-30T03:13:15Z

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author:	VSadov
Assignees:	-
Labels:	`area-NativeAOT-coreclr`
Milestone:	-

ghost · 2023-03-30T03:31:58Z

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch, @kunalspathak
See info in area-owners.md if you want to be subscribed.

Issue Details

    // At this point the unusedDefs map should contain only unused values.
    if (checkUnusedValues)
    {
        for (auto kvp : unusedDefs)
        {
            GenTree* node = kvp.Key();
            assert(node->IsUnusedValue() && "found an unmarked unused value");      <==== here
            assert(!node->isContained() && "a contained node should have a user");
        }
    }

 	KernelBase.dll!wil::details::DebugBreak(void)	Unknown
>	clrjit_win_x64_x64.dll!assertAbort(const char * why, const char * file, unsigned int line) Line 304	C++
 	clrjit_win_x64_x64.dll!LIR::Range::CheckLIR(Compiler * compiler, bool checkUnusedValues) Line 1692	C++
 	[Inline Frame] clrjit_win_x64_x64.dll!Lowering::CheckBlock(Compiler * compiler, BasicBlock *) Line 7351	C++
 	[Inline Frame] clrjit_win_x64_x64.dll!Lowering::LowerBlock(BasicBlock *) Line 7382	C++
 	clrjit_win_x64_x64.dll!Lowering::DoPhase() Line 7151	C++
 	clrjit_win_x64_x64.dll!Phase::Run() Line 62	C++
 	clrjit_win_x64_x64.dll!Compiler::compCompile(void * * methodCodePtr, unsigned int * methodCodeSize, JitFlags * compileFlags) Line 5088	C++
 	clrjit_win_x64_x64.dll!Compiler::compCompileHelper(CORINFO_MODULE_STRUCT_ * classPtr, ICorJitInfo * compHnd, CORINFO_METHOD_INFO * methodInfo, void * * methodCodePtr, unsigned int * methodCodeSize, JitFlags * compileFlags) Line 7025	C++
 	[Inline Frame] clrjit_win_x64_x64.dll!Compiler::compCompile::__l164::__Body::Run(Compiler::compCompile::__l2::__JITParam *) Line 6181	C++
 	clrjit_win_x64_x64.dll!Compiler::compCompile(CORINFO_MODULE_STRUCT_ * classPtr, void * * methodCodePtr, unsigned int * methodCodeSize, JitFlags * compileFlags) Line 6185	C++
 	[Inline Frame] clrjit_win_x64_x64.dll!jitNativeCode::__l8::__Body::Run::__l6::__Body::Run(jitNativeCode::__l8::__Body::Run::__l5::__JITParam *) Line 7668	C++
 	clrjit_win_x64_x64.dll!`jitNativeCode'::`8'::__Body::Run(jitNativeCode::__l2::__JITParam * __JITpParam) Line 7671	C++
 	clrjit_win_x64_x64.dll!jitNativeCode(CORINFO_METHOD_STRUCT_ * methodHnd, CORINFO_MODULE_STRUCT_ * classPtr, ICorJitInfo * compHnd, CORINFO_METHOD_INFO * methodInfo, void * * methodCodePtr, unsigned int * methodCodeSize, JitFlags * compileFlags, void * inlineInfoPtr) Line 7695	C++
 	clrjit_win_x64_x64.dll!CILJit::compileMethod(ICorJitInfo * compHnd, CORINFO_METHOD_INFO * methodInfo, unsigned int flags, unsigned char * * entryAddress, unsigned int * nativeSizeOfCode) Line 272	C++
 	jitinterface_x64.dll!JitCompileMethod(CorInfoExceptionClass * * ppException, ICorJitCompiler * pJit, void * thisHandle, void * * callbacks, CORINFO_METHOD_INFO * methodInfo, unsigned int flags, unsigned char * * entryAddress, unsigned int * nativeSizeOfCode) Line 34	C++
 	ilc.exe!ILCompiler_RyuJit_Internal_JitInterface_CorInfoImpl__JitCompileMethod�()	Unknown
 	ilc.exe!ILCompiler_RyuJit_Internal_JitInterface_CorInfoImpl__CompileMethodInternal() Line 358	Unknown
 	ilc.exe!ILCompiler_RyuJit_Internal_JitInterface_CorInfoImpl__CompileMethod() Line 62	Unknown
 	ilc.exe!ILCompiler_RyuJit_ILCompiler_RyuJitCompilation__CompileSingleMethod_0() Line 190	Unknown
 	ilc.exe!System_Threading_Tasks_Parallel_System_Threading_Tasks_Parallel___c__DisplayClass19_0_1<System___Canon>___ForWorker_b__1() Line 1060	Unknown
 	ilc.exe!System_Threading_Tasks_Parallel_System_Threading_Tasks_TaskReplicator_Replica__Execute() Line 79	Unknown
 	ilc.exe!S_P_CoreLib_System_Threading_ExecutionContext__RunFromThreadPoolDispatchLoop() Line 268	Unknown
 	ilc.exe!S_P_CoreLib_System_Threading_Tasks_Task__ExecuteWithThreadLocal() Line 2353	Unknown
 	ilc.exe!S_P_CoreLib_System_Threading_ThreadPoolWorkQueue__Dispatch() Line 919	Unknown
 	ilc.exe!S_P_CoreLib_System_Threading_ThreadPool__DispatchCallback() Line 376	Unknown

Author:	VSadov
Assignees:	-
Labels:	`area-CodeGen-coreclr`, `untriaged`, `area-NativeAOT-coreclr`
Milestone:	-

VSadov · 2023-03-30T03:34:21Z

I will disable the offending test. Just need to be sure it is the only one affected.

VSadov · 2023-03-30T03:38:08Z

This must be a relatively recent issue. I run tests with chk runtime frequently and did not see it.
However my base (5d88ff4) was a few days old. The issue must be newer than that commit.

VSadov · 2023-03-30T03:55:03Z

This is the only test affected. With System.Net.Sockets.Tests excluded chk/ret NativeAOT Libraries tests pass locally.

EgorBo · 2023-03-30T11:39:00Z

@VSadov can you please remind me how do I build a specific BCL test suite with NAOT? I think last time I tried it only worked for the whole BCL suite and took several hours

VSadov · 2023-03-30T16:29:30Z

I think last time I tried it only worked for the whole BCL suite and took several hours

I takes about 12-15 minutes to run the whole suite on AMD 5950X from clean state, so it is not too bad. I run the whole suite fairly often. It does need a fast machine with lots of memory though.

There were some instructions for selective compiling/running tests in #78717

jkotas · 2023-03-30T16:31:26Z

build.cmd -s clr.aot+libs -rc checked -c Release
cd src\libraries\System.Net.Sockets\tests\FunctionalTests
..\..\..\..\..\dotnet.cmd build /t:Test -c Release /p:TestNativeAot=true /p:CoreCLRConfiguration=checked

VSadov · 2023-03-30T17:24:37Z

@EgorBo - FYI. The test has been disabled on NativeAOT in #84114. If you decide to run the whole suite, you'd need to sync to before that change.

(also if you decide to run the whole suite on your new machine 🚀, do share how long it took. ;)

dotnet-issue-labeler bot added the area-NativeAOT-coreclr label Mar 30, 2023

ghost added the untriaged New issue has not been triaged by the area owner label Mar 30, 2023

VSadov mentioned this issue Mar 30, 2023

[NativeAOT] Making thread local storage completely managed. #84060

Merged

jkotas added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Mar 30, 2023

jkotas removed the area-NativeAOT-coreclr label Mar 30, 2023

VSadov mentioned this issue Mar 30, 2023

Disable System.Net.Sockets\tests\FunctionalTests\System.Net.Sockets.Tests.csproj on NativeAOT #84114

Merged

jkotas mentioned this issue Mar 30, 2023

Proper type name parser for native AOT compiler #83657

Merged

JulieLeeMSFT removed the untriaged New issue has not been triaged by the area owner label Mar 30, 2023

JulieLeeMSFT added this to the 8.0.0 milestone Mar 30, 2023

EgorBo self-assigned this Mar 31, 2023

EgorBo mentioned this issue Mar 31, 2023

Fix assert when SpanHelpers.SequenceEqual is unused #84155

Merged

ghost added the in-pr There is an active PR which will close this issue when it is merged label Mar 31, 2023

EgorBo closed this as completed in #84155 Mar 31, 2023

ghost removed the in-pr There is an active PR which will close this issue when it is merged label Mar 31, 2023

ghost locked as resolved and limited conversation to collaborators Apr 30, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[NativeAOT] Assertion failed 'node->IsUnusedValue() && "found an unmarked unused value"' - when compiling System.Net.Sockets.Tests #84112

[NativeAOT] Assertion failed 'node->IsUnusedValue() && "found an unmarked unused value"' - when compiling System.Net.Sockets.Tests #84112

VSadov commented Mar 30, 2023 •

edited

Loading

ghost commented Mar 30, 2023

ghost commented Mar 30, 2023

VSadov commented Mar 30, 2023

VSadov commented Mar 30, 2023 •

edited

Loading

VSadov commented Mar 30, 2023

EgorBo commented Mar 30, 2023

VSadov commented Mar 30, 2023 •

edited

Loading

jkotas commented Mar 30, 2023

VSadov commented Mar 30, 2023

[NativeAOT] Assertion failed 'node->IsUnusedValue() && "found an unmarked unused value"' - when compiling System.Net.Sockets.Tests #84112

[NativeAOT] Assertion failed 'node->IsUnusedValue() && "found an unmarked unused value"' - when compiling System.Net.Sockets.Tests #84112

Comments

VSadov commented Mar 30, 2023 • edited Loading

ghost commented Mar 30, 2023

ghost commented Mar 30, 2023

VSadov commented Mar 30, 2023

VSadov commented Mar 30, 2023 • edited Loading

VSadov commented Mar 30, 2023

EgorBo commented Mar 30, 2023

VSadov commented Mar 30, 2023 • edited Loading

jkotas commented Mar 30, 2023

VSadov commented Mar 30, 2023

VSadov commented Mar 30, 2023 •

edited

Loading

VSadov commented Mar 30, 2023 •

edited

Loading

VSadov commented Mar 30, 2023 •

edited

Loading