Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tracking] Decide if the tags order matter when creating meter or instrument #86614

Closed
tarekgh opened this issue May 23, 2023 · 2 comments
Closed

Comments

@tarekgh
Copy link
Member

tarekgh commented May 23, 2023

As we began caching the instruments or meters that are created, we aim to avoid creating new objects if the creation parameters (such as name, unit, tags) match any of the cached objects. The issue at hand is whether we should consider the comparison of tags to be order sensitive or not. This is a decision we need to make.

@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label May 23, 2023
@ghost ghost added the untriaged New issue has not been triaged by the area owner label May 23, 2023
@tarekgh tarekgh self-assigned this May 23, 2023
@tarekgh tarekgh added area-System.Diagnostics.Metric and removed untriaged New issue has not been triaged by the area owner needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels May 23, 2023
@tarekgh tarekgh added this to the 8.0.0 milestone May 23, 2023
@JamesNK
Copy link
Member

JamesNK commented May 23, 2023

From other thread:

What I'm getting at is that if you specify meter options with the same name and two tags in different MeterFactory.Create calls:

  • Create(Name = "Test", Tags = "A=1, B=2")
  • Create(Name = "Test", Tags = "B=2, A=1")

The result is two different meters. Do exporters, e.g. Prometheus, care about tag order?

I don't know if it's important or not, I just want to make sure a metrics expert has thought about it.

@tarekgh
Copy link
Member Author

tarekgh commented May 26, 2023

This is addressed by #86740

@tarekgh tarekgh closed this as completed May 26, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Jun 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants