-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HttpStress] massive cancellation errors in HTTP/3 #87957
Comments
Tagging subscribers to this area: @dotnet/ncl Issue DetailsSometime around merging #84793, we started to see cancellations of QUIC connection attempts. They are in high number, e.g.:19 995, 19 803. They tend to occur around the same timestamp, the operation duration is very fast and mostly not cancelled:
They started occuring around the time I merged #84793 with the msquic hack, but they are still there after it's removal in #87926, which makes me believe it's not the causation but correlation. This is offshoot from #77126, which I believe was wrongly re-opened, as this seemed to be a new error. Whole exception stack:
|
I see the problem here and it was there before the hack. When we fail to create a new runtime/src/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/HttpConnectionPool.cs Lines 917 to 928 in ce953d0
Then, for a while, new connection to that authority is not allowed and the same exception is reported back. What happens with stress is that we have random cancellation and if that cancellation ends up right in the middle of connection establishment, we'll blocklist the server. The fix should be to not to blocklist in case of cancellation. |
Sometime around merging #84793, we started to see cancellations of QUIC connection attempts. They are in high number, e.g.:19 995, 19 803. They tend to occur around the same timestamp, the operation duration is very fast and mostly not cancelled:
They started occuring around the time I merged #84793 with the msquic hack, but they are still there after it's removal in #87926, which makes me believe it's not the causation but correlation.
This is offshoot from #77126, which I believe was wrongly re-opened, as this seemed to be a new error.
Whole exception stack:
The text was updated successfully, but these errors were encountered: