Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add the pattern to the summary of GeneratedRegex partial method #88121

Closed
pawchen opened this issue Jun 28, 2023 · 2 comments · Fixed by #88175
Closed

Please add the pattern to the summary of GeneratedRegex partial method #88121

pawchen opened this issue Jun 28, 2023 · 2 comments · Fixed by #88175

Comments

@pawchen
Copy link

pawchen commented Jun 28, 2023

Description

Currently only lengthy explanation is available. I would like to see the original pattern on mouse hover, it is much clearer for me, especially for patterns that contain several capture groups, (?<...>) is very easy to spot compared to bullet points.

image

Reproduction Steps

[GeneratedRegex(@"Origin (?<version>(?<num>\d+[a-z]?|\d+\.\d+(?:.\d)?)(?<sr> SR\d)?) (?<type>.*)")]
private static partial Regex GetOriginVersionPattern();

Expected behavior

The pattern used to generate the partial method should be included in the xml document summary.

Actual behavior

Only verbose explanations are given.

Regression?

No response

Known Workarounds

Not use the GeneratedRegex feature.

Configuration

VS 17.6.4
project targets .NET 7
.NET SDK 7.0.304

Other information

No response

@ghost ghost added the untriaged New issue has not been triaged by the area owner label Jun 28, 2023
@ghost
Copy link

ghost commented Jun 28, 2023

Tagging subscribers to this area: @dotnet/area-system-text-regularexpressions
See info in area-owners.md if you want to be subscribed.

Issue Details

Description

Currently only lengthy explanation is available. I would like to see the original pattern on mouse hover, it is much clearer for me, especially for patterns that contain several capture groups, (?<...>) is very easy to spot compared to bullet points.

image

Reproduction Steps

[GeneratedRegex(@"Origin (?<version>(?<num>\d+[a-z]?|\d+\.\d+(?:.\d)?)(?<sr> SR\d)?) (?<type>.*)")]
private static partial Regex GetOriginVersionPattern();

Expected behavior

The pattern used to generate the partial method should be included in the xml document summary.

Actual behavior

Only verbose explanations are given.

Regression?

No response

Known Workarounds

Not use the GeneratedRegex feature.

Configuration

No response

Other information

No response

Author: pawchen
Assignees: -
Labels:

area-System.Text.RegularExpressions

Milestone: -

@stephentoub
Copy link
Member

#88175

@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Jun 29, 2023
@ghost ghost removed in-pr There is an active PR which will close this issue when it is merged untriaged New issue has not been triaged by the area owner labels Jun 29, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Jul 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants