Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Improvements in CMake Generator Expressions to Simplify our Build System's ones #93370

Closed
Tracked by #88688
ivdiazsa opened this issue Oct 11, 2023 · 2 comments · Fixed by #93678
Closed
Tracked by #88688

Use Improvements in CMake Generator Expressions to Simplify our Build System's ones #93370

ivdiazsa opened this issue Oct 11, 2023 · 2 comments · Fixed by #93678
Assignees
@ivdiazsa
Labels
area-Infrastructure-coreclr in-pr There is an active PR which will close this issue when it is merged
Milestone
9.0.0

Comments

@ivdiazsa
Copy link
Contributor

ivdiazsa commented Oct 11, 2023 •
edited
Loading

Now that we officially CMake 3.20 in our build system, we can simplify some of our generator expressions using some new features. For example, we can now simplify $<OR:$<CONFIG:X>,$<CONFIG:Y>>:-flag> to just $<$<CONFIG:X,Y>:-flag>.

Find the expressions like that in the build system and simplify them.
@ivdiazsa ivdiazsa mentioned this issue Oct 11, 2023
Open
17 tasks
@ghost ghost added the untriaged New issue has not been triaged by the area owner label Oct 11, 2023
@ghost
Copy link

ghost commented Oct 11, 2023

Tagging subscribers to this area: @cston
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: ivdiazsa
Assignees: -
Labels:

area-System.Linq.Expressions
Milestone: -

@ivdiazsa ivdiazsa changed the title Use improvements in CMake generator expressions to simplify our CMake generator expressions (there are many cases where we can simplify expressions like $<OR:$<CONFIG:X>,$<CONFIG:Y>>:-flag> to $<$<CONFIG:X,Y>:-flag>) Use Improvements in CMake Generator Expressions to Simplify our Build System's ones Oct 11, 2023
@ivdiazsa ivdiazsa added area-Infrastructure-coreclr and removed area-System.Linq.Expressions untriaged New issue has not been triaged by the area owner labels Oct 11, 2023
@ghost
Copy link

ghost commented Oct 11, 2023

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: ivdiazsa
Assignees: -
Labels:

area-Infrastructure-coreclr
Milestone: -

@ivdiazsa ivdiazsa self-assigned this Oct 11, 2023
@ivdiazsa ivdiazsa added this to the 9.0.0 milestone Oct 11, 2023
@ivdiazsa ivdiazsa linked a pull request Oct 18, 2023 that will close this issue
Replaced CMake's Repeated CONFIG Expressions With Their Condensed Counterparts #93678
Merged
@ivdiazsa ivdiazsa added the in-pr There is an active PR which will close this issue when it is merged label Oct 18, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Nov 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ivdiazsa ivdiazsa

Labels
area-Infrastructure-coreclr in-pr There is an active PR which will close this issue when it is merged
Projects
Infrastructure Backlog
Status: Closed
Milestone
9.0.0
Development

Successfully merging a pull request may close this issue.

Replaced CMake's Repeated CONFIG Expressions With Their Condensed Counterparts
1 participant
@ivdiazsa