Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regressions in System.Net.Primitives.Tests.IPAddressPerformanceTests #94300

Closed
performanceautofiler bot opened this issue Oct 31, 2023 · 3 comments
Closed

Regressions in System.Net.Primitives.Tests.IPAddressPerformanceTests #94300

performanceautofiler bot opened this issue Oct 31, 2023 · 3 comments
Labels
arch-x64 needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners os-linux Linux OS (any supported distro) runtime-coreclr specific to the CoreCLR runtime tenet-performance Performance related issue tenet-performance-benchmarks Issue from performance benchmark

Comments

@performanceautofiler
Copy link

Run Information

Name Value
Architecture x64
OS ubuntu 22.04
Queue TigerUbuntu
Baseline c3348745580807daccbdf21c5c9a62c004b9c776
Compare 0f2cf16467dbd376bf4ac3040262699f850a9155
Diff Diff
Configs CompilationMode:tiered, RunKind:micro

Regressions in System.Net.Primitives.Tests.IPAddressPerformanceTests

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio
10.56 ns 13.60 ns 1.29 0.12 False

graph
Test Report

Repro

General Docs link: https://github.com/dotnet/performance/blob/main/docs/benchmarking-workflow-dotnet-runtime.md

git clone https://github.com/dotnet/performance.git
python3 .\performance\scripts\benchmarks_ci.py -f net8.0 --filter 'System.Net.Primitives.Tests.IPAddressPerformanceTests*'

Payloads

Baseline
Compare

System.Net.Primitives.Tests.IPAddressPerformanceTests.TryFormat(address: 143.24.20.36)

ETL Files

Histogram

JIT Disasms

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository
@performanceautofiler performanceautofiler bot added arch-x64 os-linux Linux OS (any supported distro) runtime-coreclr specific to the CoreCLR runtime untriaged New issue has not been triaged by the area owner labels Oct 31, 2023
@performanceautofiler performanceautofiler bot mentioned this issue Oct 31, 2023
Closed
@cincuranet cincuranet changed the title [Perf] Linux/x64: 1 Regression on 10/23/2023 7:14:46 AM Regressions in System.Net.Primitives.Tests.IPAddressPerformanceTests Nov 2, 2023
@cincuranet cincuranet removed the untriaged New issue has not been triaged by the area owner label Nov 2, 2023
@cincuranet cincuranet transferred this issue from dotnet/perf-autofiling-issues Nov 2, 2023
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Nov 2, 2023
@ghost ghost added the untriaged New issue has not been triaged by the area owner label Nov 2, 2023
@cincuranet
Copy link
Contributor

The diff is clean 7a0727e...2959e1a pointing to #93835 (cc @EgorBo). The previous improvement has diff 44a2b2d...1658fa9 and contains also the #93429.

@cincuranet cincuranet added tenet-performance Performance related issue tenet-performance-benchmarks Issue from performance benchmark labels Nov 2, 2023
@EgorBo
Copy link
Member

EgorBo commented Nov 3, 2023

pointing to #93835 (cc @EgorBo).

that PR was reverted so should not be the culprit

@cincuranet
Copy link
Contributor

That's correct. Looks like the revert reverted the previous improvement.

@ghost ghost removed the untriaged New issue has not been triaged by the area owner label Nov 7, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Dec 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
arch-x64 needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners os-linux Linux OS (any supported distro) runtime-coreclr specific to the CoreCLR runtime tenet-performance Performance related issue tenet-performance-benchmarks Issue from performance benchmark
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@EgorBo @cincuranet @jeffschwMSFT