Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide subsets for AltJits for RISC-V and LoongArch64 #97712

Closed
MichalPetryka opened this issue Jan 30, 2024 · 3 comments · Fixed by #110282
Closed

Provide subsets for AltJits for RISC-V and LoongArch64 #97712

MichalPetryka opened this issue Jan 30, 2024 · 3 comments · Fixed by #110282
Labels
arch-loongarch64 arch-riscv Related to the RISC-V architecture area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI in-pr There is an active PR which will close this issue when it is merged
Milestone

Comments

@MichalPetryka
Copy link
Contributor

Currently, there's no way to test JIT output for RISC-V and LoongArch64 without using hardware based on them, as such it'd be useful to have AltJits for them available in order to be able to verify JIT codegen on them after changes.
Since those platforms aren't officially supported, they should be under separate opt-in build subsets.

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jan 30, 2024
@ghost ghost added the untriaged New issue has not been triaged by the area owner label Jan 30, 2024
@ghost
Copy link

ghost commented Jan 30, 2024

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

Currently, there's no way to test JIT output for RISC-V and LoongArch64 without using hardware based on them, as such it'd be useful to have AltJits for them available in order to be able to verify JIT codegen on them after changes.
Since those platforms aren't officially supported, they should be under separate opt-in build subsets.

Author: MichalPetryka
Assignees: -
Labels:

area-CodeGen-coreclr

Milestone: -

@SingleAccretion SingleAccretion added this to the Future milestone Jan 30, 2024
@ghost ghost removed the untriaged New issue has not been triaged by the area owner label Jan 30, 2024
@SingleAccretion SingleAccretion added arch-loongarch64 arch-riscv Related to the RISC-V architecture labels Jan 30, 2024
@am11
Copy link
Member

am11 commented Mar 26, 2024

If the existing Clr.AllJits subset cannot support the community platforms without making it optional, something like Clr.AltJitsCommunity would do the trick (and maybe rename Clr.AllJits to keep these aspects scalable).

@hez2010
Copy link
Contributor

hez2010 commented Nov 29, 2024

I think it's fine to build all jits available in Clr.AllJits as it can help verify whether a change would break the community platforms or not with the existing CI setup.

@dotnet-policy-service dotnet-policy-service bot added the in-pr There is an active PR which will close this issue when it is merged label Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arch-loongarch64 arch-riscv Related to the RISC-V architecture area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI in-pr There is an active PR which will close this issue when it is merged
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants