Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add beginnings of WebAssembly build support for mono. #33551

Merged
merged 10 commits into from
Apr 10, 2020
Merged

Add beginnings of WebAssembly build support for mono. #33551

merged 10 commits into from
Apr 10, 2020

Conversation

vargaz
Copy link
Contributor

@vargaz vargaz commented Mar 13, 2020

No description provided.

@vargaz vargaz changed the title Add beginnings of WebAssembly build support for mono. [WIP] Add beginnings of WebAssembly build support for mono. Mar 13, 2020
@vargaz vargaz force-pushed the wasm-build branch 9 times, most recently from fdc4655 to 19cbd13 Compare March 17, 2020 02:38
@vargaz
Copy link
Contributor Author

vargaz commented Mar 17, 2020

Currently fails with:
020-03-17T02:50:24.6725593Z bash : error : setlocale: LC_ALL: cannot change locale (en_US.UTF-8) [/__w/1/s/src/mono/mono.proj]
Seems to be a problem with the docker container.

@vargaz vargaz force-pushed the wasm-build branch 5 times, most recently from 97577ca to cc0d78a Compare March 17, 2020 23:29
@vargaz
Copy link
Contributor Author

vargaz commented Mar 19, 2020

The mono build seems to work now, but the libraries build fails with:
Please install CMake 3.14.2 or newer from http://www.cmake.org/download/ or https://apt.kitware.com and ensure it is on your path.
It looks like a problem with the 18.04 ubuntu docker image.

@vargaz
Copy link
Contributor Author

vargaz commented Mar 19, 2020

The docker image seems to contain cmake 3.10:
https://github.com/dotnet/dotnet-buildtools-prereqs-docker/blob/master/src/ubuntu/18.04/amd64/Dockerfile

@steveisok steveisok mentioned this pull request Mar 19, 2020
Closed
@vargaz
Copy link
Contributor Author

vargaz commented Mar 23, 2020

So changing the os to 'wasm' causes the packaging step to fail because it expects 'WebAssembly'.

@vargaz
Copy link
Contributor Author

vargaz commented Apr 3, 2020

So the runtime build seems to work now but the libraries wasm build is broken by the bump of the docker image version.

@vargaz
Copy link
Contributor Author

vargaz commented Apr 3, 2020

The wasm libraries build now fails with:
EXEC : error : No usable version of clang found. [/__w/1/s/src/libraries/Native/build-native.proj]

@akoeplinger akoeplinger mentioned this pull request Apr 3, 2020
Merged
@vargaz vargaz force-pushed the wasm-build branch 3 times, most recently from 735c94a to 9522a56 Compare April 7, 2020 13:46
@akoeplinger akoeplinger mentioned this pull request Apr 9, 2020
Merged
@akoeplinger
Merge remote-tracking branch 'upstream/master' into wasm-build
74819de 
# Conflicts:
#	eng/Subsets.props
#	eng/native/configureplatform.cmake
#	src/mono/Directory.Build.props
#	src/mono/mono.proj
@akoeplinger
Bump webassembly image
1da9cc8
@akoeplinger
Use Mono runtime for webassembly builds
a4b955f
@akoeplinger akoeplinger changed the title [WIP] Add beginnings of WebAssembly build support for mono. Add beginnings of WebAssembly build support for mono. Apr 10, 2020
@akoeplinger akoeplinger merged commit fd4831f into dotnet:master Apr 10, 2020
@vargaz vargaz deleted the wasm-build branch April 11, 2020 07:28
am11
am11 reviewed Apr 13, 2020
View reviewed changes
src/libraries/Native/build-native.sh
Comment on lines +57 to +58
export CLR_CC=$(which emcc)
export CLR_CXX=$(which em++)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A nit, typically posix-y command -v is preferred over which in this repo. (same goes for which false below)

Copy link
Member

@akoeplinger akoeplinger Apr 14, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@am11 I tried that but it didn't work since we expect the full path in CLR_CC and command -v doesn't do that (for false at least)

@ghost ghost locked as resolved and limited conversation to collaborators Dec 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@akoeplinger akoeplinger akoeplinger approved these changes

@am11 am11 am11 left review comments

@jeromelaban jeromelaban jeromelaban left review comments

@jkotas jkotas jkotas left review comments

@EgorBo EgorBo Awaiting requested review from EgorBo

@marek-safar marek-safar Awaiting requested review from marek-safar

@steveisok steveisok Awaiting requested review from steveisok

Assignees
No one assigned
Labels
area-Build-mono
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@vargaz @akoeplinger @am11 @jeromelaban @jkotas @marek-safar