Fix for runtime constraint checking for default interface methods #34889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I couldn't figure out the best area label to add to this PR. Please help me learn by adding exactly one area label. |
mangod9
commented
Apr 13, 2020
mangod9
changed the title
jkotas
approved these changes
Apr 14, 2020
davidwrighton
approved these changes
Apr 14, 2020
|
All R2R outerloop failures are known, and validated that the new test succeeded. |
|
yup. I have duped those two issues. Thanks! |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed fix for this issue: #1674. It appears since Instantiation context is not passed in for SatisfiesConstraint the concrete instantiation type is not correctly compared.