Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Use PackageReferences in libraries #34893

Closed
wants to merge 1 commit into from

Conversation

ViktorHofer
Copy link
Member

@ViktorHofer ViktorHofer commented Apr 13, 2020

Contributes towards #31844 and #31872.

Unsure what we should do with .NET Framework testing. Still build the testhost or switch to a "self-contained" mode.

cc @ericstj @safern @Anipik

@ghost
Copy link

ghost commented Apr 13, 2020

Tagging @ViktorHofer as an area owner. If you would like to be tagged for a label, please notify danmosemsft.

@ViktorHofer ViktorHofer changed the title Use PackageReferences in libraries [WIP] Use PackageReferences in libraries Apr 13, 2020
<SystemDiagnosticsDebugVersion>4.3.0</SystemDiagnosticsDebugVersion>
<SystemDiagnosticsTracingVersion>4.3.0</SystemDiagnosticsTracingVersion>
<SystemDynamicRuntimeVersion>4.3.0</SystemDynamicRuntimeVersion>
<SystemMemoryVersion>4.5.3</SystemMemoryVersion>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like these aren't the newest versions /cc @joperezr

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's correct, they aren't. How did you get these reference numbers @ViktorHofer? From looking at Darc, it seems like release/2.1 branch in corefx (where System.Memory is built and shipped) doesn't have a default channel any longer, which would explain why we didn't get the new one if we used dependency flow. I would suggest two things: one is to update that channel to have all serviced package versions from 2.1, and the other one is to run my validation task somewhere in the build to make sure that these package versions are still the latest.

@ghost ghost locked as resolved and limited conversation to collaborators Dec 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants