-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[mono] Integrate xharness tool (iOS) #35316
Conversation
Tagging subscribers to this area: @ViktorHofer |
Tagging subscribers to this area: @directhex |
Trying to fix the hang issue here: dotnet/xharness#73 |
The hang is prevented here to unblock you but the app will still fail to install on the Simulator: I am tracking the installation issue here: |
Created two issues to track this:
Should be easy to solve. |
So fix was already checked couple of hours ago but we have problems with arcade and cannot seem to publish the new package: There is a fix in arcade apparently but it will take time. So let me know if this becomes blocker for you and I can send you a manually built package or I can push one to the feed or something that will unblock you |
@EgorBo looks like the XHarness tool will expect the app to shut down itself after the tests are done, otherwise it doesn't know if there are more logs to come. Is it something you can implement? |
@premun it's already implemented in this PR, see changes in runtime.m https://github.com/dotnet/runtime/pull/35316/files#diff-8c2a0ec87d7100c3ad4942fb4d36a1d4L276 |
@EgorBo if you wish, keep it as a feature and we can add the autoexit option too. But up to you, this seems as less code :) Also, could I ask you to build a new app for me with the exiting from the dummy test file I sent you on Teams? I will do another round of testing on Monday |
"In progress" legs are actually green in AzDO. |
xharness-tool works but not quite stable: it doesn't quit when tests are finished, also I don't see any file with test results.
Steps to run a test: