Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete managedOsxBuild et. al #35356

Merged
merged 2 commits into from
Apr 30, 2020
Merged

Conversation

sdmaclea
Copy link
Contributor

Remove managedOsxBuild
Remove managedTestBuildOsGroup
Remove managedTestBuildOsSubgroup

@ghost
Copy link

ghost commented Apr 23, 2020

Tagging subscribers to this area: @ViktorHofer
Notify danmosemsft if you want to be subscribed.

@sdmaclea sdmaclea requested a review from directhex April 23, 2020 19:07
@sdmaclea
Copy link
Contributor Author

sdmaclea commented Apr 23, 2020

@trylek I assumed this is what you were looking for when you asked to clean up managedTestBuildOsGroup/managedTestBuildOsSubgroup

@naricc @directhex I am not sure if this will negatively impact Mono.

I suspect I was too zealous with this and Mono needs to run test built for different arch, but I'll wait for feedback

Remove managedOsxBuild
Remove managedTestBuildOsGroup
Remove managedTestBuildOsSubgroup
@naricc
Copy link
Contributor

naricc commented Apr 24, 2020

I'm not sure if I appreciate what this PR does. What is managedTestBuildOsGroup/Subgroup vs OsGroup/Subgroup? What does removing it do?

@sdmaclea
Copy link
Contributor Author

This was driven by @trylek comment

  1. Get rid of managedBuildOsGroup/Subgroup as it should be superfluous with this change

The PR he was referring to was splitting the build of AnyOS AnyCPU CoreCLR tests (TargetGeneric) from target specific tests.

managedBuildOsGroup/Subgroup allowed building tests on one platform and running them on another.

As I was removing this, I saw cases where Mono wasn't setting osGroup the same as managedBuildOsGroup. I copied @naricc because I saw you authored the patch to run these tests for Mono.

@naricc
Copy link
Contributor

naricc commented Apr 27, 2020

It seems like mono doesn't need this, so it should be ok to remove as far as mono builds go.

@sdmaclea sdmaclea closed this Apr 27, 2020
@sdmaclea sdmaclea reopened this Apr 27, 2020
Copy link
Member

@trylek trylek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for cleaning this up!

@ghost
Copy link

ghost commented Apr 29, 2020

Hello @sdmaclea!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@sdmaclea sdmaclea merged commit 5b9fe8f into dotnet:master Apr 30, 2020
@sdmaclea sdmaclea deleted the TestDecouple branch April 30, 2020 01:43
sdmaclea added a commit that referenced this pull request Apr 30, 2020
sdmaclea added a commit that referenced this pull request Apr 30, 2020
@sdmaclea
Copy link
Contributor Author

Reverted by #35647
This caused outerloop failures because outerloop builds are still running OSX tests.

Will revisit after #35645 goes in and then is generalized for all pipes.

@ghost ghost locked as resolved and limited conversation to collaborators Dec 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants