-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove obsolete managedOsxBuild et. al #35356
Conversation
Tagging subscribers to this area: @ViktorHofer |
@trylek I assumed this is what you were looking for when you asked to clean up @naricc @directhex I am not sure if this will negatively impact Mono. I suspect I was too zealous with this and Mono needs to run test built for different arch, but I'll wait for feedback |
Remove managedOsxBuild Remove managedTestBuildOsGroup Remove managedTestBuildOsSubgroup
I'm not sure if I appreciate what this PR does. What is managedTestBuildOsGroup/Subgroup vs OsGroup/Subgroup? What does removing it do? |
This was driven by @trylek comment
The PR he was referring to was splitting the build of AnyOS AnyCPU CoreCLR tests (
As I was removing this, I saw cases where Mono wasn't setting |
It seems like mono doesn't need this, so it should be ok to remove as far as mono builds go. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for cleaning this up!
Hello @sdmaclea! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
Remove managedOsxBuild
Remove managedTestBuildOsGroup
Remove managedTestBuildOsSubgroup