Code

Spannified internals of BigInteger#35565

Code

Merged

jeffhandley merged 99 commits intodotnet:maindotnet/runtime:mainfrom sakno:issue-22609sakno/runtime:issue-22609Copy head branch name to clipboardOct 8, 2021

+1,374-1,409

Commits

Commits on Apr 27, 2020

• Unsafe pointers replaced with managed pointers

  sakno

  committed
  51260fd

  Copy full SHA for 51260fd

Commits on Apr 28, 2020

• Duplicate code replaced with static local

  sakno

  committed
  27cd3b6

  Copy full SHA for 27cd3b6

• Spannified internals

  sakno

  committed
  f6d1f89

  Copy full SHA for f6d1f89

• Spannified compare

  sakno

  committed
  d8af4fd

  Copy full SHA for d8af4fd

• Spannified div/rem operations

  sakno

  committed
  ca1cf5c

  Copy full SHA for ca1cf5c

• Minus two array allocations for each bitwise operation

  sakno

  committed
  d89cdea

  Copy full SHA for d89cdea

Commits on Apr 29, 2020

• Removed redundant locals

  sakno

  committed
  7a6a0d8

  Copy full SHA for 7a6a0d8

• Sync with upstream

  sakno

  committed
  eb64ad1

  Copy full SHA for eb64ad1

• Code review feedback (code style)

  sakno

  committed
  ba2a01e

  Copy full SHA for ba2a01e

• Code review feedback

  sakno

  committed
  49317c5

  Copy full SHA for 49317c5

• LeadingZeroes replaced with BitOperations

  sakno

  committed
  fa47aea

  Copy full SHA for fa47aea

• stackalloc in Divide without remainder

  sakno

  committed
  ea7c29b

  Copy full SHA for ea7c29b

• Reduced memory allocation for bitwise operations

  sakno

  committed
  a1e5006

  Copy full SHA for a1e5006

• Managed pointer replaced with Span

  sakno

  committed
  f19ff53

  Copy full SHA for f19ff53

• Removed namespace imports

  sakno

  committed
  6e8705f

  Copy full SHA for 6e8705f

Commits on Apr 30, 2020

• Removed delegate type

  sakno

  committed
  34893a3

  Copy full SHA for 34893a3

• Reduced memory allocation in the end of each bitwise operation

  sakno

  committed
  5992406

  Copy full SHA for 5992406

• Code review feedback

  sakno

  committed
  2b7b7ba

  Copy full SHA for 2b7b7ba

• Removed redundant array allocation

  sakno

  committed
  03313c1

  Copy full SHA for 03313c1

• Trivial division moved to stack alloc

  sakno

  committed
  92618a4

  Copy full SHA for 92618a4

• Reduced memory allocation for divide operator

  sakno

  committed
  65f2701

  Copy full SHA for 65f2701

• Reduced memory allocation for shift operations

  sakno

  committed
  b5a77b4

  Copy full SHA for b5a77b4

• Array pooling for Square operation

  sakno

  committed
  ea35011

  Copy full SHA for ea35011

• Fixed bound check for bitwise operations

  sakno

  committed
  9da2cb3

  Copy full SHA for 9da2cb3

• Multiply now uses array pooling

  sakno

  committed
  ed6d159

  Copy full SHA for ed6d159

• Removed namespace import

  sakno

  committed
  e53dc14

  Copy full SHA for e53dc14

• Reduced memory allocation for Add

  sakno

  committed
  6d84785

  Copy full SHA for 6d84785

• Removed swap of arguments

  sakno

  committed
  a4482e0

  Copy full SHA for a4482e0

• Reduced memory allocations for multiply operator

  sakno

  committed
  b0752ea

  Copy full SHA for b0752ea

• Reduced memory allocations for modulo operator

  sakno

  committed
  8c9cfdc

  Copy full SHA for 8c9cfdc

• Temporarily spannify ActualLength method

  sakno

  committed
  15b4eef

  Copy full SHA for 15b4eef

• Spannify FastReducer

  sakno

  committed
  fb263bf

  Copy full SHA for fb263bf

Commits on May 1, 2020

• Spannify initial parts of GCD alg

  sakno

  committed
  f71442d

  Copy full SHA for f71442d

• Simple GCD test for debugging

  sakno

  committed
  156b7ac

  Copy full SHA for 156b7ac

• Simple test for debugging

  sakno

  committed
  036c535

  Copy full SHA for 036c535

• Removed debug code

  sakno

  committed
  7fa1438

  Copy full SHA for 7fa1438

• Spannified GCD algorithm

  sakno

  committed
  a4c4891

  Copy full SHA for a4c4891

• Removed arg passing by ref

  sakno

  committed
  900ac48

  Copy full SHA for 900ac48

• Complete migration of gcd to span

  sakno

  committed
  3a5a117

  Copy full SHA for 3a5a117

• Removed memory allocation for trivial case of GCD

  sakno

  committed
  97ee31b

  Copy full SHA for 97ee31b

• Reorganize utility code

  sakno

  committed
  4e6a403

  Copy full SHA for 4e6a403

• Removed redundant parameter

  sakno

  committed
  dd69148

  Copy full SHA for dd69148

Commits on May 2, 2020

• Reduced memory alloc for trivial case of Pow alg

  sakno

  committed
  1f84dc7

  Copy full SHA for 1f84dc7

• Use span for trivial modulus pow case

  sakno

  committed
  875cd16

  Copy full SHA for 875cd16

• Use span for trivial cases of pow modulus

  sakno

  committed
  19086a6

  Copy full SHA for 19086a6

• Fixed buffer cleanup

  sakno

  committed
  64597dc

  Copy full SHA for 64597dc

• Reduced memory allocation of ModPow operations

  sakno

  committed
  f86c616

  Copy full SHA for f86c616

• BitsBuffer replaced with span

  sakno

  committed
  7509c59

  Copy full SHA for 7509c59

• Reorganize utility methods

  sakno

  committed
  61e028b

  Copy full SHA for 61e028b

• Reduced visibility scope

  sakno

  committed
  4ff0bd5

  Copy full SHA for 4ff0bd5

• Removed temporary code for bits cleanup

  sakno

  committed
  9e2242e

  Copy full SHA for 9e2242e

• Fill leading bits with zeroes

  sakno

  committed
  98b7fa8

  Copy full SHA for 98b7fa8

• Unify order of parameters

  sakno

  committed
  f5a5b9e

  Copy full SHA for f5a5b9e

• Unify order of parameters

  sakno

  committed
  f713703

  Copy full SHA for f713703

• Unify order of parameters

  sakno

  committed
  0f1f935

  Copy full SHA for 0f1f935

• Reuse the same local var

  sakno

  committed
  c9ba177

  Copy full SHA for c9ba177

• Sync with master

  sakno

  committed
  1b12fde

  Copy full SHA for 1b12fde

• Removed whtespace

  sakno

  committed
  e1afe77

  Copy full SHA for e1afe77

Commits on May 3, 2020

• Code review feedback

  sakno

  committed
  f085cc4

  Copy full SHA for f085cc4

• Avoid misleading with Span.CopyTo

  sakno

  committed
  30132f0

  Copy full SHA for 30132f0

• Clarify purpose of slicing

  Show description for 0344cb2
  

  sakno

  and

  gfoidl

  authored
  0344cb2

  Copy full SHA for 0344cb2

• Replace mentioning of uint[] in comments

  sakno

  committed
  4c6dd0b

  Copy full SHA for 4c6dd0b

• Fixed code formatting issues

  sakno

  committed
  35bd53c

  Copy full SHA for 35bd53c

Commits on Aug 30, 2020

• Merge with master

  sakno

  committed
  b7b3460

  Copy full SHA for b7b3460

• Share StackAllocThreshold const

  sakno

  committed
  9f498b0

  Copy full SHA for 9f498b0

• Ignore const threshold values in Release config

  sakno

  committed
  7bc63c8

  Copy full SHA for 7bc63c8

• Literal field cannot be discovered with TypeInfo.GetDeclaredField

  sakno

  committed
  dd7bdef

  Copy full SHA for dd7bdef

• Removed invalid assertion

  sakno

  committed
  fe53099

  Copy full SHA for fe53099

• Removed invalid assertion

  sakno

  committed
  55d949f

  Copy full SHA for 55d949f

• Removed invalid assertion

  sakno

  committed
  61d470d

  Copy full SHA for 61d470d

Commits on Dec 15, 2020

• Sync with upstream

  sakno

  committed
  8a7ba77

  Copy full SHA for 8a7ba77

• Code review feedback

  sakno

  committed
  808c12c

  Copy full SHA for 808c12c

• Fixed header

  sakno

  committed
  7db731c

  Copy full SHA for 7db731c

Commits on Jan 16, 2021

• Sync with upstream

  sakno

  committed
  8762259

  Copy full SHA for 8762259

• Fixed overflow of result buffer

  sakno

  committed
  24d2ff4

  Copy full SHA for 24d2ff4

• Reduced ctor visibility

  sakno

  committed
  60777dd

  Copy full SHA for 60777dd

Commits on Jan 18, 2021

• Eliminated bounds check

  sakno

  committed
  fa5eb5e

  Copy full SHA for fa5eb5e

Commits on Jan 20, 2021

• Returned optimization using Math.DivRem

  sakno

  committed
  ec1285d

  Copy full SHA for ec1285d

• Added braces to be consistent with other branches

  sakno

  committed
  f01d089

  Copy full SHA for f01d089

• Fixed location of the comment

  sakno

  committed
  484d6ff

  Copy full SHA for 484d6ff

• Combine slice and conversion as the single line

  sakno

  committed
  e1161f0

  Copy full SHA for e1161f0

• Combine slice and conversion as the single line

  sakno

  committed
  9855da5

  Copy full SHA for 9855da5

Commits on May 10, 2021

• Sync with upstream

  sakno

  committed
  9a22a4e

  Copy full SHA for 9a22a4e

• Merge with parsing optimizations

  sakno

  committed
  eeb2cdd

  Copy full SHA for eeb2cdd

• Reduced checks

  sakno

  committed
  1b30bb0

  Copy full SHA for 1b30bb0

• Removed redundant global const

  sakno

  committed
  fb514a1

  Copy full SHA for fb514a1

• Replaced magic consts with their named equivalents

  sakno

  committed
  b4ac5e5

  Copy full SHA for b4ac5e5

Commits on May 12, 2021

• Removed useless asserts

  sakno

  committed
  932eef3

  Copy full SHA for 932eef3

Commits on Aug 5, 2021

• Merge branch 'main' into issue-22609

  sakno

  committed
  fd0124a

  Copy full SHA for fd0124a

• Manual merge with dotnet#53984 PR

  sakno

  committed
  a4f3f22

  Copy full SHA for a4f3f22

• Review feedback (use const for stackalloc)

  sakno

  committed
  2a94300

  Copy full SHA for 2a94300

Commits on Aug 17, 2021

• Merge branch 'main' and dotnet#57297

  sakno

  committed
  82187cb

  Copy full SHA for 82187cb

Commits on Aug 24, 2021

• Sync with upstream

  sakno

  committed
  1a9cf2b

  Copy full SHA for 1a9cf2b

• Review feedback

  sakno

  committed
  4971224

  Copy full SHA for 4971224

• Unsafe code replaced with span indexer where possible

  sakno

  committed
  020e749

  Copy full SHA for 020e749

Commits on Aug 26, 2021

• Removed unused local

  sakno

  committed
  68306d1

  Copy full SHA for 68306d1

Commits on Oct 7, 2021

• Sync with upstream

  sakno

  committed
  65485fa

  Copy full SHA for 65485fa

Commits on Oct 8, 2021

• Sync with upstream

  sakno

  committed
  fe39909

  Copy full SHA for fe39909

• Review feedback

  sakno

  committed
  602574f

  Copy full SHA for 602574f